[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Infinite canvas issues
From:       "LukasT.dev () gmail ! com" <lukast ! dev () gmail ! com>
Date:       2009-07-02 16:24:48
Message-ID: 200907021824.48337.LukasT.dev () gmail ! com
[Download RAW message or body]

Today I resolved issue with update rectangle which is moved. It was in 

KisCanvas2::updateCanvasProjection(const QRect & rc)
vRect had to be translated by origin

Now the rect is in correct position from the view perspective
There is line
m_d->prescaledProjection->updateCanvasProjection(rc);
which gets rc which is in image coordinates.

in KisPrescaledProjection::updateCanvasProjection(const QRect & rc)
...
// this does not have to be moved I think -- tool calls updateCanvasProjection 
// with rc in image coordinates
m_d->projectionCache.updateUnscaledCache( rc );

// this vRect is in view coordinates (widget coordinates I suppose too) and 
// probably should be moved by origin
QRect vRect = viewRectFromImagePixels(rc);
if (!vRect.isEmpty()) {
    preScale(vRect);
}
...

I will add document origin to prescale projection and test it
If you have anything to say to this, let me know. And I invite you to play 
with the updated patch [1] ;)

Thanks
Lukas

[1] http://lukast.mediablog.sk/patches/qpainter_infinite_canvas.2.patch
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]