'Re: On-canvas preview of the brushes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: On-canvas preview of the brushes
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2009-05-05 17:04:38
Message-ID: 200905051904.39600.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On Friday 01 May 2009, LukasT.dev@gmail.com wrote:
> Hi,
>
> There are some nice commits from Cyrille in trunk about the preview of the
> brush on the canvas. So far it is little buggy. When you select the Pixel
> Brush and select the diameter e.g. 25 and try to paint, you will get the
> wrong result.
I have fixed that problem now.

Thinking about code duplication, would be worth to introduce 
KisBrushBasedPaintOpSettings to contains the code for 
paintOutlineRect/paintOutline to avoid duplication.

-- 
Cyrille Berger

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">On Friday 01 May 2009, LukasT.dev@gmail.com \
wrote:<br> &gt; Hi,<br>
&gt;<br>
&gt; There are some nice commits from Cyrille in trunk about the preview of the<br>
&gt; brush on the canvas. So far it is little buggy. When you select the Pixel<br>
&gt; Brush and select the diameter e.g. 25 and try to paint, you will get the<br>
&gt; wrong result.<br>
I have fixed that problem now.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Thinking about code duplication, would be worth to \
introduce KisBrushBasedPaintOpSettings to contains the code for \
paintOutlineRect/paintOutline to avoid duplication.<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>-- \
<br> Cyrille Berger</p></body></html>

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 