[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: koffice/krita/ui
From: Boudewijn Rempt <boud () valdyas ! org>
Date: 2009-05-01 14:05:03
Message-ID: 200905011605.04155.boud () valdyas ! org
[Download RAW message or body]
On Saturday 11 April 2009, Cyrille Berger wrote:
> SVN commit 952454 by berger:
>
> Fix: crash when croping a layer created from an imported image
>
> No reason why this bug doesn't affect branch, can someone review ?
>
This look ok. But I was wondering about setImage -- I thought I had removed it
from KisLayer, but I see we need it for the adjustment layer to get the image
bounds :-(
Btw, at the same time I saw:
void KisLayer::setSectionModelProperties(const
KoDocumentSectionModel::PropertyList &properties)
{
KisBaseNode::setSectionModelProperties(properties);
/// TODO no nope not at all, the state contains a use-visible string not
the actual property
// setOpacity( properties.at( 2 ).state.toInt() );
// setCompositeOp( const_cast<KoCompositeOp*>( image()->colorSpace()-
>compositeOp( properties.at( 3 ).state.toString() ) ) );
}
Does this mean that setting the composite op is now broken? Besides, setting
the properties is meant to alter the state of the node.
--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic