[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: usability fix for krita; stroke from outside the canvas
From: Cyrille Berger <cberger () cberger ! net>
Date: 2009-02-25 23:21:50
Message-ID: 200902260021.51172.cberger () cberger ! net
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Saturday 14 February 2009, Boudewijn Rempt wrote:
> On Friday 13 February 2009, Thomas Zander wrote:
> > Hi,
> >
> > I had some brainstorming here how to solve a problem that Krita is
> > especially hit by.
> > As you might know since the new krita canvas classes and the
> > canvasController we lost the ability to start a stroke outside of the
> > actual painting and drag the pointer into the canvas to make it still
> > paint.
> > KOffice 1.6 had it, so its a regression.
> >
> > I created a patch and it seems to work mostly OK for me for flake tools
> > (the caligraphy tool works good with it). So I think the concept is
> > sound.
> >
> > For some reason the krita tools don't have any effect with it, and I
> > don't have time to look into that right now.
> >
> > Would a good soul here be able to take a look?
> > Find attached the patch;
>
> Hm... We're not there. Some tools seem to throw the system into an infinite
> loop on canvas entry, and the flake freehand tool only starts about twenty
> pixels from inside the document edge. I'll do some more testing today.
I have added to quickly disable the workaround for the tablet tracking bug, in
kis_qpainter_canvas.cpp, just comment #define WORKAROUNT_TABLET_TRACKING_BUG
and you get a clean behaviour. Still hadn't had the opportunity to check the
patch.
--
Cyrille Berger
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">On Saturday 14 February 2009, Boudewijn Rempt \
wrote:<br> > On Friday 13 February 2009, Thomas Zander wrote:<br>
> > Hi,<br>
> ><br>
> > I had some brainstorming here how to solve a problem that Krita is<br>
> > especially hit by.<br>
> > As you might know since the new krita canvas classes and the<br>
> > canvasController we lost the ability to start a stroke outside of the<br>
> > actual painting and drag the pointer into the canvas to make it still<br>
> > paint.<br>
> > KOffice 1.6 had it, so its a regression.<br>
> ><br>
> > I created a patch and it seems to work mostly OK for me for flake tools<br>
> > (the caligraphy tool works good with it). So I think the concept is<br>
> > sound.<br>
> ><br>
> > For some reason the krita tools don't have any effect with it, and I<br>
> > don't have time to look into that right now.<br>
> ><br>
> > Would a good soul here be able to take a look?<br>
> > Find attached the patch;<br>
><br>
> Hm... We're not there. Some tools seem to throw the system into an infinite<br>
> loop on canvas entry, and the flake freehand tool only starts about twenty<br>
> pixels from inside the document edge. I'll do some more testing today.<br>
I have added to quickly disable the workaround for the tablet tracking bug, in \
kis_qpainter_canvas.cpp, just comment #define WORKAROUNT_TABLET_TRACKING_BUG<br> and \
you get a clean behaviour. Still hadn't had the opportunity to check the patch.<br> \
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic