[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Patch for KCurve and KisPerChannelFilter
From:       Дима КазакР<dimula73 () gmail ! com>
Date:       2009-02-20 18:25:40
Message-ID: ae32c1ef0902201025h61270564xfc4b56666d35c01f () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


>
>
> > 1) Look through preview mechanism, because it still slows everything down
> > much.
>
> This is something I'm also working on: right now, the preview on-canvas is
> broken (again...), but it should be working in the background, in a thread.
>

I haven't looked throught the code, but i have such a feeling that preview
is made against the whole unscaled image, isn't it? I think it would be
enough to apply filters to the smaller scaled down picture that is shown on
the screen. Of course, there would be some mathematical issues, especially
with convolution filters, but we could make interface that would allow
Filter to choose whether it needs whole image for preview. imho.

PS:
Even with Curves filter there would be issues with interpolation if we use
scaled preview. But if my memory serves me right and feelings don't lie,
Photoshop works like that. At least preview and final results differ a bit.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div \
class="Ih2E3d"><br> &gt; 1) Look through preview mechanism, because it still slows \
everything down<br> &gt; much.<br>
<br>
</div>This is something I&#39;m also working on: right now, the preview on-canvas \
is<br> broken (again...), but it should be working in the background, in a \
thread.<br></blockquote></div><br>I haven&#39;t looked throught the code, but i have \
such a feeling that preview is made against the whole unscaled image, isn&#39;t it? I \
think it would be enough to apply filters to the smaller scaled down picture that is \
shown on the screen. Of course, there would be some mathematical issues, especially \
with convolution filters, but we could make interface that would allow Filter to \
choose whether it needs whole image for preview. imho.<br> <br \
clear="all">PS:<br>Even with Curves filter there would be issues with interpolation \
if we use scaled preview. But if my memory serves me right and feelings don&#39;t \
lie, Photoshop works like that. At least preview and final results differ a bit.<br> \
<br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]