[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: bltSelection and fill bucket
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2008-11-24 19:34:32
Message-ID: 200811242034.32559.boud () valdyas ! org
[Download RAW message or body]

On Monday 24 November 2008, Cyrille Berger wrote:
> Hi,
>
> On Monday 24 November 2008, Boudewijn Rempt wrote:
> > That's weird, though, since here the src dev is the filled paint device,
> > which is isn't empty, but filled to the size of m_width and m_height.
> > Unless we do that through setting the default pixel, but that doesn't
> > seem the case, so if srcRect is correct, then this line should not be a
> > problem.
>
> Oh right it's not srcRect the problem ! Since it's srcdev... stupid me :(
>
> Now I have found the problem it's
>      if (selMask->isProbablyTotallyUnselected(QRect(dx, dy, sw, sh))) {
>          return;
>      }


That's just an optimization --we can try to remove that and see what the 
unittests do. (And write a unittest for the fillpainter....)
-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]