[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: koffice/krita/image
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2007-04-29 21:44:47
Message-ID: 478b087a0704291444p40f37405sc7e6dd4626e7197f () mail ! gmail ! com
[Download RAW message or body]

On 4/29/07, Boudewijn Rempt <boud@valdyas.org> wrote:
> On Sunday 29 April 2007, Sven Langkamp wrote:
> > On 4/29/07, Casper Boemann <cbr@boemann.dk> wrote:
> > > indeed slangkamp had worked on it a couple of weeks back
> > >
> > > maybe he can tell you more
> >
> > The explanation for this is:
> > Unlike 1.x the redo is called on every commands which is added to the
> > undo stack (due to change to qundostack).
> > Transactions are normally executed imidiately by Krita, so the redo
> > call from the undostack would cause a double redo. To prevent this i
> > put in a check to block the first redo call.
> >
> > In this case the problem was that in a KisSelectedTransaction the
> > child transaction wasn't noticed about the first redo so it still
> > blocked. I commit a fix
> >
> > I hope this clears everything up
>
> I may have messed up recently, then. On adding a layer, the layercommand's
> redo method was explicitly called, which messed up the layer model (because
> the layer got added twice, the second time failing because of an assert), so
> I removed the call to redo() -- was that right?

I think so. That was probably a call needed by the old system and
renamed it too fast instead of removing it.
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]