[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Possible bug in kis_convolution_painter.cc
From: Boudewijn Rempt <boud () valdyas ! org>
Date: 2006-03-23 6:17:44
Message-ID: 200603230717.44838.boud () valdyas ! org
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Thursday 23 March 2006 05:38, Christoph Bartoschek wrote:
> Hi,
>
> In line 118 you have:
>
> if (w < kw || h < kh || kw&1 == 0 || kh&1 == 0 || kernel->factor == 0 )
> return;
>
>
> The terms kw&1 == 0 and kh&1 == 0 are evaluated in this way: kw & (1 ==
> 0) and this is equivalent to kw & 0 and this is equivalent to 0.
> The following programm shows the difference:
>
> #include <iostream>
>
> int main()
> {
> unsigned val = 0;
> if (val & 1 == 0) {
> std::cout << "I am in" << std::endl;
> }
> if ((val & 1) == 0) {
> std::cout << "I am out" << std::endl;
> }
>
> }
I'm not sure which one it should be... Cyrille? You're our convolution guru...
--
Boudewijn Rempt
http://www.valdyas.org/fading/index.cgi
[Attachment #5 (application/pgp-signature)]
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic