[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: koffice
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2005-11-07 19:07:06
Message-ID: 200511072007.06320.boud () valdyas ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 07 November 2005 19:58, Thomas Zander wrote:
> On Monday 07 November 2005 16:34, Cyrille Berger wrote:
> > --- trunk/koffice/krita/sdk/kis_global.h #478672:478673
> > @@ -28,6 +28,7 @@
> >   #define KRITA_VERSION VERSION
> >   
> >   const Q_UINT8 Q_UINT8_MAX = UCHAR_MAX;
> > +const Q_UINT16 Q_UINT16_MAX = 65535;
>
> Is it wise to have defines that have a Q at the beginning defined in a
> Krita header file?
> I was searching for the Qt file to include when I made the mistake of only
> updating the files that used it...
>
> What about renaming this to KR_foo

Fine with me -- this is a very old relic dating from the 
Krita-as-a-wrapper-around-image-magick-days. But use KIS_ instead of KR_ -- 
we never use a KR prefix anywhere.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]