[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Smart pointers and color strategies
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2005-07-31 17:58:05
Message-ID: 200507311958.05737.boud () valdyas ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 31 July 2005 19:52, Casper Boemann wrote:
> On Sunday 31 July 2005 19:46, Boudewijn Rempt wrote:
> > Since we basicallly have only one copy of each color strategy, and since
> > we don't want to delete that copy ever -- why do we actually use smart
> > pointers for color strategies? With Krita going to the color strategy for
> > every little pixel computation, wouldn't it be smarter to use plain
> > pointers and not have the overhead of smart pointers?
>
> good point
>
> I'm not sure the overhead is that big, but I'm all for it.

I don't know either, but it's an extra function call, isn't it?

const T* operator->() const { return ptr; }

Maybe the compiler smartly inlines this...

Anyway, would it be as simple as 

perl -p -i -e's/KisStrategyColorSpaceSP/KisStrategyColorSpace\*/g'? It's worth 
a try, but first I'm going to see if I can find out why filling a selection 
hangs on the completely innocent line

 m_writable = writable;

in the tiledhline iterator constructor...

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]