[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Changing the default channel depth
From:       Patrick Julien <freak () codepimps ! org>
Date:       2004-03-08 12:14:09
Message-ID: 200403080714.09615.freak () codepimps ! org
[Download RAW message or body]

On March 8, 2004 07:10 am, Boudewijn Rempt wrote:
> On Monday 08 March 2004 13:03, Patrick Julien wrote:
> > Krita is more and more dependant on 8 bit color channels.  New code is
> > simply not using constants or macros.
> >
> > I'm considering changing the default channel depth to 16 bits instead of
> > 8, at least for CVS (i.e. non-releases).
> >
> > This way, if someone forgets, the code breaks immediately.

I don't think so, would you really type in 65535 instead of 255?  If you don't 
use downscale(), the output would always be broken.

>
> On the other hand, all new code would surely grow to be dependent on 16
> bits instead.
>
> > Suggestions?  Flames?
>
> Well, I would love 16 bits, since I cannot do a watercolour colourmodel in
> less than 16 bits :-). On the other hand, I would like it even better if we
> could just get rid of channel depth as a default: that would solve
> everthing in one go. Maybe even stop having QUANTUM defined. All these
> constants are image type dependent, and I think I want to put them in the
> image type class.

Maybe QUANTUM needs to be always 32 bit, no matter what the color channel 
depth is.

I don't want to have to define variables of different type depending on what 
channel you are working with.  That is just too much of a pain to use.

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]