[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Likely performance bug in bitBlt
From:       Patrick Julien <freak () codepimps ! org>
Date:       2004-02-21 7:53:45
Message-ID: 200402210253.45342.freak () codepimps ! org
[Download RAW message or body]

This is not a performance bug, it's just default values if you provide '-1' 
for the width or height.  This matches what QPainter does.

Of course, what you probably really want is specify the actual width and 
height.

On February 19, 2004 08:16 pm, Roger Larsson wrote:
> In KisPainter::bitBlt (core/kis_painter.cc) we have this code
> for the case when we have not given size.
>
>         if (sw == -1)
>                 sw = dsttm -> width();
>
>         if (sh == -1)
>                 sh = dsttm -> height();
>
> But the destination image is usually huge...
> This would be better since the source buffer is
> more likely to match the sizes!
>
>         if (sw == -1)
>                 sw = srctm -> width();
>
>         if (sh == -1)
>                 sh = srctm -> height();
>
> But best is probably to use the size parameters.
>
> (My mail list subscription might have failed... I will see if I get this.)
>
> /RogerL
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]