From kde-kimageshop  Wed Feb 11 23:22:19 2004
From: Sven Langkamp <longamp () reallygood ! de>
Date: Wed, 11 Feb 2004 23:22:19 +0000
To: kde-kimageshop
Subject: Re: Docking GUI
Message-Id: <200402120022.19457.longamp () reallygood ! de>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=107654149520954

Am Wednesday 11 February 2004 02:05 schrieb Patrick Julien:
> On February 10, 2004 12:17 pm, Sven Langkamp wrote:
> > Hi,
> >
> > now you can try out the dockers.
> > still todo:
> > -add menu items and removing the old ones(does somebody have experience
> > with this?)
> > -the docker should be better arranged (idea?)
> >
> > Sven
>
> OK, here I go again.  Not that I want to discourage you, but you really,
> really need to honor the style of files that you are modifying.
Sorry, I will pay more attention on this for future changes.
According to the one-header-one-class rule, kis_sidebar should be splited into 
several files and removed. 
Will the indention change? At the moment I use the 8 spaces recommended by the 
HACKING file, even I like 4 spaces more. 

> I'm not saying my style is better than anyone else, but consistency does
> have value.  If you don't believe me, look at the Krayon code before I
> started working on it, you can't even tell when blocks begin and end since
> every developer working on that code kept is own style.
>
> Other than that, good work, this is really where we want to go for  a Krita
> GUI.  See my previous post about the mediator design pattern.
I don't know much about design patterns, but I think I will buy the GOF book.
For the dockers I'm currently looking on the observer pattern. The observers 
would be the big color chooser, the small one in the cotrol docker and 
kis_view. Subjekt would be the fore/background color. Thanks for the hint.

Sven
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop