--===============0385302963==
Content-Type: multipart/signed; protocol="application/pgp-signature";
	micalg=pgp-sha1; boundary="Boundary-02=_ESWj/3wWGMiGBA8";
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit


--Boundary-02=_ESWj/3wWGMiGBA8
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: signed data
Content-Disposition: inline

On Wednesday 15 October 2003 16:02, Patrick Julien wrote:

<...>

Added some notes to the design document.

> Steal from the Gimp forever?

As far as I'm concerned, no -- on the other hand, there's not much literatu=
re=20
on developing pixel-painter applications, and the Gimp is about the only=20
powerful example available in the wild. But as soon as I know that the pain=
t=20
core is solid -- KisPainter and everything under it, and I can load brushes=
,=20
preferably dynamic, and perhaps fix some issues with the userinterface, the=
n=20
I'm going to do the things that _do_ interest me. From that point, either=20
people cry 'Stop! Halt! You're messing up our perfectly fine=20
photoshop-clone!', or Krita won't have much similarity to the gimp anymore.=
=20
Of course, it's quite possible that I will fail horribly before I'm even=20
half-way there. Or that you will tell me to please stop messing with things=
 I=20
don't understand...

>
> Code wise:
>
> You should use Q_INT32 instead of int.

Changed.

>
> don't use //, if you want to comment out a large section of code, use #if=
 0

Why? I rather disliked the complaints of the compiler about unused variable=
s,
so I commented the code out.

>
> You actually have a huge memory leak in your new drawPolyline method.=20
> Check out the destructor of KisPixelData.

I though that I didn't need to delete that, because of the shared pointer -=
=2D=20
did I misunderstand that bit? But don't tease: is the right solution to set=
=20
KisPixelData.owner to true?

>
> Adding // ??? doesn't really do anything but add clout to the code.

I think you mean clutter, but well, here I have to disagree. That's a marke=
r=20
for me to remind me to add comments when I know what that bit is about. It=
=20
flags me that this needs my attention.

> Yeah, why did you reorder data members in KisView, KisPixelData, etc?  Th=
ey
> look awful now (tab vs. spaces) and for no apparent reason either.

Well, in some cases, create a little order out of a long, chaotic list, in=
=20
other cases just in the course of ordinary editing. Adding stuff, removing=
=20
lines, noticing that the indent didn't fit, pressing tab in XEmacs to fix=20
what I removed. And sometimes comments spill over to the next line, and giv=
es=20
the appearance of reordering, as in kispixeldata.cpp, where the actual orde=
r=20
hasn't changed. Tabs vs spaces are a bit of a problem, I'm afraid I have no=
=20
easy solution. If you don't mind very greatly -- i.e., if this is going
to hinder you working, then I'll investigate ways of teaching XEmacs to use=
=20
tabs when working in the krita tree.

And about kis_view.h; I'll probably ream out that file in its entirety when=
 I=20
start working on the user interface.

>
> Also, if you want to start renaming classes, i.e. KisToolBrush to
> ToolBrush, change the file name too.

??? I don't think I renamed any class as such? Oh, wait -- it _was_ called=
=20
BrushTool, and I have started implementing a new brush, without even lookin=
g=20
at the old code, and I sort of assumed that it would be KisToolBrush,=20
consistent with the filename. So, actually it's even more consistent now...

Anyway, new diff at the same place...

=2D-=20
Boudewijn Rempt | http://www.valdyas.org/index2.html

--Boundary-02=_ESWj/3wWGMiGBA8
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQA/jWSEdaCcgCmN5d8RAm5DAJ9w5/Y8MECt4lXGASqCItsup79Q6gCgnfu0
r/hvPNLwuhCFlaOC0Kr2crY=
=63nR
-----END PGP SIGNATURE-----

--Boundary-02=_ESWj/3wWGMiGBA8--


--===============0385302963==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kimageshop mailing list
kimageshop@mail.kde.org
http://mail.kde.org/mailman/listinfo/kimageshop

--===============0385302963==--