[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kafka
Subject:    Re: [PATCH]: #2: basic moving for kafka :o)
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2001-04-25 16:34:29
[Download RAW message or body]

On Wednesday 25 April 2001 17:58, Emmanuel Touzery wrote:
> Le Mercredi 25 Avril 2001 12:38, Nikolas Zimmermann a écrit :
> > > No problem! here you have them :o)
> > > if you want to look at something, i'm not too sure how to say "empty
> > > the selection" (it's commented in the code), and sometimes (one time on
> > > 6 in my tests, maybe) it can trigger a segfault outside of my code. now
> > > i should improve that code and work on other things on kafka as well (i
> > > need to do that for my school so i will work on it). i was thinking
> > > about #2/#3 moving/resizing pictures/embed maybe?? (i need to hardcode
> > > "img" and "embed" or any better idea??).
> >
> > How do you mean that?
>
> ;o) then i wasn't looking at the plugin code ;o) well, forget about that.
>
> > >or i could maybe improve the selection code?
> > > or maybe resizing tables? well, i have tons of choices ;o)
> >
> > hehe
> >
> > > hope this helps,
> >
> > no :(
> > Doesn't work again!
> > Those patches are not against _latest_ CVS :(
> > I can't apply
>
> ok, here is a new version...
grml _STILL_ doesn't work
it seems you check out with _sticky_ tag
you'll need a fresh cvs co

Bye
 Bye
  Niko

> please consider what i was saying about correct way of emptying the
> selection + knowing it's empty. for instance, if i do a
> selectionRange.deleteContents(), i can't find how to check it's empty (??).
> when the document is opened, the selection is initialised strangely:
>    DOM::Range tempRange(htmlDocument());
>    selectionRange = tempRange;
>
> my patch tries to empty the selection (currently it does
> selectionRange.setStart(targetNode, 0);selectionRange.setEnd(targetNode,
> 0); )
>
> i'd like to have a clean emptySelection() and "if (!selectionIsEmpty())" in
> my isSelected(Node). well, you get the idea... to do that, i would need to
> add a boolean in the class kafkahtmlpart, and it would not be very nice.
> but there must be a "good" way of doing it...what do you think?
>
> also my code is not really happy when meeting a picture or such right now
> (crash!). looking into it, though i'd like to clean the selection bit
> first.
>
> > > Emmanuel
> >
> > Bye
> >  Bye
> >   Niko
>
> emmanuel..

["kafkahtmlpart.h.diff" (text/x-c++)]


["kafkahtmlpart.cpp.diff" (kafkahtmlpart.cpp.diff)]


-- 
Nikolas Zimmermann
wildfox@kde.org
_______________________________________________
Kde-kafka mailing list
Kde-kafka@master.kde.org
http://master.kde.org/mailman/listinfo/kde-kafka


[prev in list] [next in list] [prev in thread] [next in thread]