[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-imaging
Subject:    Re: [Kde-imaging] Reg Libkipi attributes() function
From:       Tom Albers <tomalbers () kde ! nl>
Date:       2006-07-18 18:08:32
Message-ID: 200607182008.33070.tomalbers () kde ! nl
[Download RAW message or body]

Maybe it's prettier to move the call to the if statement...
I'll do the same for sendimages.

Toma

Op dinsdag 18 juli 2006 19:56, schreef Vardhman Jain:
> Hi,
>      I am little confused whether I should now change the code of
> flickrexport plugin to check the hasFeature(HostSupportsTags) before using
> the attributes function or not. The code can very well just call the
> attributes() function without checking the feature as it would
> automatically get an empty string list in case application doesn't support
> the "tags" key.
>
> Let me know ur opinion.
>
> Vardhman
>
> On 7/18/06, Tom Albers <tomalbers@kde.nl> wrote:
> > Op dinsdag 18 juli 2006 19:06, schreef u:
> > > Op maandag 17 juli 2006 22:18, schreef Vardhman Jain:
> > > >        I have started breaking libkipi binary compatibility (:)).
> > > > Just added the HostSupportsTags feature in the enum list of features.
> > > > Now Applications can support this feature.
> > >
> > > Do any app do that already? I tried digikam trunk, but your code from
> > > flickr applied to sendimages:
> > >
> > >             //Tags from the database
> > >             QMap <QString, QVariant> attribs=info.attributes();
> > >             QStringList tagsFromDatabase;
> > >
> > >             if (m_interface->hasFeature(KIPI::HostSupportsTags))
> > >                 tagsFromDatabase=attribs["tags"].asStringList();
> > >
> > >             kdDebug() << "Tags: " << tagsFromDatabase << endl;
> > >
> > > Stays empty for me....
> > >
> > > Toma
> >
> > Ignore that, I found the comment in digiKam. I think the comment should
> > be removed by the way.
> >
> > Toma
> > _______________________________________________
> > Kde-imaging mailing list
> > Kde-imaging@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-imaging
_______________________________________________
Kde-imaging mailing list
Kde-imaging@kde.org
https://mail.kde.org/mailman/listinfo/kde-imaging
[prev in list] [next in list] [prev in thread] [next in thread]