[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Migrating Pology to Python 3
From:       Johnny Jazeix <jazeix () gmail ! com>
Date:       2022-12-18 12:13:25
Message-ID: CAEtcAPGcEmGa86-tuccVGsA6Jgf6++=wystE3qUAmKnCHKPMMg () mail ! gmail ! com
[Download RAW message or body]

Hi,

I've spotted an issue when using posieve with check_rules or check-spell
and wanted to output in xml.
https://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_rules.py#L211
does not like the decode().
The same exists in
https://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_spell.py#L116

I'm not sure if only removing the " .decode(locale.getpreferredencoding() "
or how to replace it to keep this functionality.

Cheers,

Johnny

Le sam. 8 oct. 2022 à 18:04, Karl Ove Hufthammer <karl@huftis.org> a écrit :

> Adrian Chaves skreiv 08.10.2022 17:11:
> >
> > This is caused by
> > https://kingant.net/2019/01/rounding-numbers-in-python-2-and-python-3/
> >
> > When plural forms are found, the average is calculated and rounded. In
> > Python 2, round(2.5) is 3, in Python 3 round(2.5) is 2.
> >
> > I have no strong opinion on the matter, but I am slightly inclined to
> > keep the Python 3 behavior on this.
> >
> Yes, I see no reason not to use Python's default rounding rules. But is
> there a reason that the average and not the sum is calculated
> (Chusslove)? After all, the sum *is* the number of words in the English
> source text (or translation).
>
>
> --
> Karl Ove Hufthammer
>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><div>Hi,</div><div><br></div><div>I&#39;ve spotted an \
issue when using posieve with check_rules or check-spell and wanted to output in \
xml.</div><div><a href="https://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_r \
ules.py#L211">https://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_rules.py#L211</a> \
does not like the decode().<br></div><div>The same exists in <a \
href="https://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_spell.py#L116">http \
s://invent.kde.org/sdk/pology/-/blob/python3/sieve/check_spell.py#L116</a></div><div><br></div><div>I&#39;m \
not sure if only removing the &quot; \
<code>.decode(locale.getpreferredencoding()</code>

&quot; or how to replace it to keep this \
functionality.</div><div><br></div><div>Cheers,</div><div><br></div><div>Johnny<br></div></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Le  sam. 8 oct. 2022 Ã   18:04, \
Karl Ove Hufthammer &lt;<a href="mailto:karl@huftis.org">karl@huftis.org</a>&gt; a \
écrit  :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Adrian Chaves skreiv \
08.10.2022 17:11:<br> &gt;<br>
&gt; This is caused by <br>
&gt; <a href="https://kingant.net/2019/01/rounding-numbers-in-python-2-and-python-3/" \
rel="noreferrer" target="_blank">https://kingant.net/2019/01/rounding-numbers-in-python-2-and-python-3/</a><br>
 &gt;<br>
&gt; When plural forms are found, the average is calculated and rounded. In <br>
&gt; Python 2, round(2.5) is 3, in Python 3 round(2.5) is 2.<br>
&gt;<br>
&gt; I have no strong opinion on the matter, but I am slightly inclined to <br>
&gt; keep the Python 3 behavior on this.<br>
&gt;<br>
Yes, I see no reason not to use Python's default rounding rules. But is <br>
there a reason that the average and not the sum is calculated <br>
(Chusslove)? After all, the sum *is* the number of words in the English <br>
source text (or translation).<br>
<br>
<br>
-- <br>
Karl Ove Hufthammer<br>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]