From kde-i18n-doc Sun Jul 26 06:49:37 2020 From: Simon Depiets Date: Sun, 26 Jul 2020 06:49:37 +0000 To: kde-i18n-doc Subject: Re: Language-Team field Message-Id: X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=159574621513445 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--000000000000a69a0605ab529c63" --000000000000a69a0605ab529c63 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I've put a PR for this change in order to use KDE locales and locale names, I'm not 100% confident it won't break so could you have a try? It should handle langCode pt_BR and Brazil Portuguese team name. https://invent.kde.org/sdk/lokalize/-/merge_requests/2 Simon Le jeu. 9 avr. 2020 =C3=A0 03:30, Albert Astals Cid a =C3= =A9crit : > El dimecres, 8 d=E2=80=99abril de 2020, a les 1:55:18 CEST, Simon Depiets= va > escriure: > > The languageToString function only takes one parameter, the Language > enum. > > There is no function that returns a language name from a Language + > Country > > combo. > > Ah, then maybe you want to use KLanguageName::nameForCode > > Cheers, > Albert > > > > > Le mer. 8 avr. 2020 =C3=A0 05:51, Albert Astals Cid a = =C3=A9crit : > > > > > El dimarts, 7 d=E2=80=99abril de 2020, a les 16:12:28 CEST, Simon Dep= iets va > > > escriure: > > > > Hello, > > > > The language is Automated by default and the values are based on a > > > QLocale > > > > enum which doesn't offer Brazilian Portuguese, nor British English > for > > > > instance (although they offer Phoenician). > > > > https://doc.qt.io/qt-5/qlocale.html#Language-enum > > > > > > Yes it does, Portuguese for Language and Brazil for Country. > > > > > > Cheers, > > > Albert > > > > > > > > > > > In recent versions of Lokalize you can override the Language-Team b= y > > > > project or for the whole application. > > > > Asking translators to update this value when onboarding them should > be > > > > enough? > > > > Otherwise I can hard code the default value in Lokalize (mailing > lists > > > are > > > > already hardcoded) > > > > > > > > Simon > > > > > > > > Le mar. 7 avr. 2020 =C3=A0 21:56, Luiz Fernando Ranghetti < > > > elchevive68@gmail.com> > > > > a =C3=A9crit : > > > > > > > > > Em seg., 6 de abr. de 2020 =C3=A0s 17:59, Albert Astals Cid < > aacid@kde.org> > > > > > escreveu: > > > > > > > > > > > > El dilluns, 6 d=E2=80=99abril de 2020, a les 20:06:20 CEST, Lui= z Fernando > > > > > Ranghetti va escriure: > > > > > > > Hi guys, > > > > > > > > > > > > > > One of our (pt_BR) translators pointed to a wrong name of > language > > > on > > > > > > > Language-Team field in .po headers made by Lokalize. > > > > > > > > > > > > > > It sets to: > > > > > > > > > > > > > > "Language-Team: Portuguese \n" > > > > > > > > > > > > > > while it should be: > > > > > > > > > > > > > > "Language-Team: Brazilian Portuguese >\n" > > > > > > > > > > > > > > I know we can override it in Lokalize but I prefer a proper > > > solution > > > > > > > (if there is any). > > > > > > > > > > > > I really don't understand the problem you're having. > > > > > > > > > > > > Are you saying that Lokalize is "defaulting" to Portuguese > instead of > > > > > "Brazilian Portuguese"? > > > > > > > > > > Yes, thats the "problem" > > > > > > > > > > > Do you have your target language set as "Brazilian Portuguese" > in the > > > > > settings? > > > > > > > > > > No, only one translator of our team has (the one which raises thi= s > > > > > issue to me), the other 3 ou 4 that occasionally translate also u= se > > > > > the default. > > > > > > > > > > What I'm asking is how can I or someone change the default to > > > > > "Brazilian Portuguese", where does it come from so we can change = it > > > > > for all translators including the new ones on future. > > > > > > > > > > Regards, > > > > > > > > > > Luiz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --=20 Simon Depiets --000000000000a69a0605ab529c63 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
I've put a PR for this change in order to u= se KDE locales and locale names, I'm not 100% confident it won't br= eak so could you have a try?
It should handle langCode pt_BR = and Brazil Portuguese team name.
https://invent.kde.org/sdk/lokalize/-/merge_req= uests/2
Simon

<= div dir=3D"ltr" class=3D"gmail_attr">Le=C2=A0jeu. 9 avr. 2020 =C3=A0=C2=A00= 3:30, Albert Astals Cid <aacid@kde.org<= /a>> a =C3=A9crit=C2=A0:
El dimecres, 8 d=E2=80=99abril de 2020, a les 1:55:18 CEST, Sim= on Depiets va escriure:
> The languageToString function only takes one parameter, the Language e= num.
> There is no function that returns a language name from a Language + Co= untry
> combo.

Ah, then maybe you want to use KLanguageName::nameForCode

Cheers,
=C2=A0 Albert

>
> Le mer. 8 avr. 2020 =C3=A0 05:51, Albert Astals Cid <aacid@kde.org> a =C3=A9crit : >
> > El dimarts, 7 d=E2=80=99abril de 2020, a les 16:12:28 CEST, Simon= Depiets va
> > escriure:
> > > Hello,
> > > The language is Automated by default and the values are base= d on a
> > QLocale
> > > enum which doesn't offer Brazilian Portuguese, nor Briti= sh English for
> > > instance (although they offer Phoenician).
> > > https://doc.qt.io/qt-5/qlocale.html#= Language-enum
> >
> > Yes it does, Portuguese for Language and Brazil for Country.
> >
> > Cheers,
> >=C2=A0 =C2=A0Albert
> >
> > >
> > > In recent versions of Lokalize you can override the Language= -Team by
> > > project or for the whole application.
> > > Asking translators to update this value when onboarding them= should be
> > > enough?
> > > Otherwise I can hard code the default value in Lokalize (mai= ling lists
> > are
> > > already hardcoded)
> > >
> > > Simon
> > >
> > > Le mar. 7 avr. 2020 =C3=A0 21:56, Luiz Fernando Ranghetti &l= t;
> > elchev= ive68@gmail.com>
> > > a =C3=A9crit :
> > >
> > > > Em seg., 6 de abr. de 2020 =C3=A0s 17:59, Albert Astals= Cid <aacid@kde.org>
> > > > escreveu:
> > > > >
> > > > > El dilluns, 6 d=E2=80=99abril de 2020, a les 20:06= :20 CEST, Luiz Fernando
> > > > Ranghetti va escriure:
> > > > > > Hi guys,
> > > > > >
> > > > > > One of our (pt_BR) translators pointed to a w= rong name of language
> > on
> > > > > > Language-Team field in .po headers made by Lo= kalize.
> > > > > >
> > > > > > It sets to:
> > > > > >
> > > > > > "Language-Team: Portuguese <kde-i18n-pt_BR@kde.org= >\n"
> > > > > >
> > > > > > while it should be:
> > > > > >
> > > > > > "Language-Team: Brazilian Portuguese <= ;kde-i18n-pt_BR= @kde.org>\n"
> > > > > >
> > > > > > I know we can override it in Lokalize but I p= refer a proper
> > solution
> > > > > > (if there is any).
> > > > >
> > > > > I really don't understand the problem you'= re having.
> > > > >
> > > > > Are you saying that Lokalize is "defaulting&q= uot; to Portuguese instead of
> > > > "Brazilian Portuguese"?
> > > >
> > > > Yes, thats the "problem"
> > > >
> > > > > Do you have your target language set as "Braz= ilian Portuguese" in the
> > > > settings?
> > > >
> > > > No, only one translator of our team has (the one which = raises this
> > > > issue to me), the other 3 ou 4 that occasionally transl= ate also use
> > > > the default.
> > > >
> > > > What I'm asking is how can I or someone change the = default to
> > > > "Brazilian Portuguese", where does it come fr= om so we can change it
> > > > for all translators including the new ones on future. > > > >
> > > > Regards,
> > > >
> > > > Luiz
> > > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>






--
Simon Depiets
--000000000000a69a0605ab529c63--