[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D25929: l10n: Add svn2git rules to import l10n*/scripts/ from SVN
From: Alexander Potashev <noreply () phabricator ! kde ! org>
Date: 2020-04-24 9:50:05
Message-ID: 713f16a173edc200f3a8ab6e04abf652 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
aspotashev added a comment.
In D25929#656114 <https://phabricator.kde.org/D25929#656114>, @nalvarez wrote:
> I think you should commit this as-is and we can do changes later directly in \
kde-ruleset.
Did it a few minutes ago with "arc patch D25929 \
<https://phabricator.kde.org/D25929> && arc land arcpatch-D25929".
> These rules are incidentally importing COPYING, INSTALL, README, subdirs, \
teamnames, debian/, and some .po files, which were in the kde-i18n/ root before the \
move but aren't in scripts/. They certainly shouldn't be present in git after r414920 \
(currently they are <https://github.com/aspotashev/converted-scripty-v2/tree/0c9d22462abb37d6ac973133821607aeaaa9b21a>, \
I'll fix that). But should they be present in git in the pre-move history, or should \
they be removed like the translation dirs are? I //think// they should be removed, \
but I'm not sure what to do about COPYING.
I think it would be fine to fix in new commits and keep the history as is.
> There's also the issue of //current// versions of l10n having no COPYING (no \
license info for scripts //or// translations) but that's not for me to fix :) It will \
have to be added either to SVN scripts/ now, or to git after the conversion. (Orrrr I \
could do evil anachronistic edits and add a COPYING to commits that never had one in \
SVN...)
In other KDE code repositories nobody is trying to rewrite the whole history, \
developers just change licenses headers and/or add COPYING files in new Git commits. \
And I don't think you can add COPYING to the old revisions before receiving \
permission to relicense from all the past contributors.
REPOSITORY
R221 KDE Ruleset
REVISION DETAIL
https://phabricator.kde.org/D25929
To: aspotashev, #localization, aacid, ltoscano, pino, nalvarez
Cc: bcooksley, nalvarez, pino, ltoscano, aacid, #localization
[Attachment #3 (text/html)]
<table><tr><td style="">aspotashev added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D25929">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D25929#656114" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D25929#656114</a>, <a \
href="https://phabricator.kde.org/p/nalvarez/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@nalvarez</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I think you should commit this as-is and we \
can do changes later directly in kde-ruleset.</p></div> </blockquote>
<p>Did it a few minutes ago with "arc patch <a \
href="https://phabricator.kde.org/D25929" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D25929</a> && arc land \
arcpatch-D25929".</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>These \
rules are incidentally importing COPYING, INSTALL, README, subdirs, teamnames, \
debian/, and some .po files, which were in the kde-i18n/ root before the move but \
aren't in scripts/. They certainly shouldn't be present in git after \
r414920 (<a href="https://github.com/aspotashev/converted-scripty-v2/tree/0c9d22462abb37d6ac973133821607aeaaa9b21a" \
class="remarkup-link" target="_blank" rel="noreferrer">currently they are</a>, \
I'll fix that). But should they be present in git in the pre-move history, or \
should they be removed like the translation dirs are? I <em>think</em> they should be \
removed, but I'm not sure what to do about COPYING.</p></blockquote>
<p>I think it would be fine to fix in new commits and keep the history as is.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>There's also the issue of <em>current</em> versions of l10n having \
no COPYING (no license info for scripts <em>or</em> translations) but that's not \
for me to fix :) It will have to be added either to SVN scripts/ now, or to git after \
the conversion. (Orrrr I could do evil anachronistic edits and add a COPYING to \
commits that never had one in SVN...)</p></blockquote>
<p>In other KDE code repositories nobody is trying to rewrite the whole history, \
developers just change licenses headers and/or add COPYING files in new Git commits. \
And I don't think you can add COPYING to the old revisions before receiving \
permission to relicense from all the past contributors.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R221 KDE Ruleset</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D25929">https://phabricator.kde.org/D25929</a></div></div><br \
/><div><strong>To: </strong>aspotashev, Localization, aacid, ltoscano, pino, \
nalvarez<br /><strong>Cc: </strong>bcooksley, nalvarez, pino, ltoscano, aacid, \
Localization<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic