[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D28227: Use same logic for "no extension" case with Duplicate feature
From: Albert Astals Cid <noreply () phabricator ! kde ! org>
Date: 2020-04-04 13:58:34
Message-ID: b58914cc6edaae831f3c21be508e1984 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
aacid added inline comments.
INLINE COMMENTS
> dolphinview.cpp:740
> const QString originalExtension = originalFileName.right(extension.size());
> - duplicateURL.setPath(i18nc("<file path><filename> copy.<extension>", \
> "%1%2 copy%3", directoryPath, originalFilenameWithoutExtension, \
> originalExtension)); + duplicateURL.setPath(originalDirectoryPath + \
> i18nc("<filename> copy.<extension>", "%1 copy", originalFilenameWithoutExtension) + \
> originalExtension)); }
i tihnk i would remove the .<extension> part, it's not part of the translatable \
string so it can be a bit confusing, also it's not like it gives translators anything \
they can work with, no?
I mean why would it translate differently whether the filename has an extension or \
not?
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D28227
To: ngraham, #dolphin, elvisangelaccio, arojas, meven, pino, #localization
Cc: aacid, kfm-devel, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, \
Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, \
emmanuelp, mikesomov
[Attachment #3 (text/html)]
<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D28227">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D28227#inline-162652">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">dolphinview.cpp:740</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span \
class="n">originalExtension</span> <span style="color: #aa2211">=</span> <span \
class="n">originalFileName</span><span class="p">.</span><span \
class="n">right</span><span class="p">(</span><span class="n">extension</span><span \
class="p">.</span><span class="n">size</span><span class="p">());</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span class="n">duplicateURL</span><span class="p">.</span><span \
class="n">setPath</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span class="bright">i18nc</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"<file path><filename> \
copy.<extension>"</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #766510"><span class="bright">"%1%2 \
copy%3"</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span class="n"><span \
class="bright">directoryPath</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n"><span class="bright">originalFilenameWithoutExtension</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span> <span \
class="n">originalExtension</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">duplicateURL</span><span class="p">.</span><span \
class="n">setPath</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">originalDirectoryPath</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> \
</span><span class="n"><span class="bright">i18nc</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"<filename> copy.<extension>"</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #766510"><span class="bright">"%1 \
copy"</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span class="n"><span \
class="bright">originalFilenameWithoutExtension</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">+</span></span> <span class="n">originalExtension</span><span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">i \
tihnk i would remove the .<extension> part, it's not part of the \
translatable string so it can be a bit confusing, also it's not like it gives \
translators anything they can work with, no?</p>
<p style="padding: 0; margin: 8px;">I mean why would it translate differently whether \
the filename has an extension or not?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D28227">https://phabricator.kde.org/D28227</a></div></div><br \
/><div><strong>To: </strong>ngraham, Dolphin, elvisangelaccio, arojas, meven, pino, \
Localization<br /><strong>Cc: </strong>aacid, kfm-devel, nikolaik, pberestov, \
iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, \
navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic