[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D25333: scripty: Look for helper scripts in the current script's parent directory
From:       Pino Toscano <noreply () phabricator ! kde ! org>
Date:       2019-12-08 16:48:59
Message-ID: 51fa5bd8372406b7f81b3c939e1a68bd () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  There are various issues here:
  
  - we are touching even branches that are dead or in maintenance mode, which means \
                an high risk of issues
  - the same 4 lines of patterns is repeated over and over
  - the way to get the directory of a script is overly verbose, using realpath is way \
easier/faster...  
  Even considered the above, what is the actual use case for these intrusive changes?
  All the scripts assume that there is a structure like:
  
  - l10n
    - templates
    - scripts
    - lang1
    - lang2
    - langN
  
  so even if `scripts` is moved away from SVN, the simple way to move this work again \
is to symlink the directory with the scripts as new `scripts` subdirectory.

REPOSITORY
  R883 Subversion

REVISION DETAIL
  https://phabricator.kde.org/D25333

To: aspotashev, #localization, pino
Cc: pino, ltoscano, nalvarez, #localization


[Attachment #3 (text/html)]

<table><tr><td style="">pino requested changes to this revision.<br />pino added a \
comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25333">View \
Revision</a></tr></table><br /><div><div><p>There are various issues here:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">we are touching even branches that are dead or in \
maintenance mode, which means an high risk of issues</li> <li \
class="remarkup-list-item">the same 4 lines of patterns is repeated over and \
over</li> <li class="remarkup-list-item">the way to get the directory of a script is \
overly verbose, using realpath is way easier/faster...</li> </ul>

<p>Even considered the above, what is the actual use case for these intrusive \
changes?<br /> All the scripts assume that there is a structure like:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">l10n<ul class="remarkup-list">
<li class="remarkup-list-item">templates</li>
<li class="remarkup-list-item">scripts</li>
<li class="remarkup-list-item">lang1</li>
<li class="remarkup-list-item">lang2</li>
<li class="remarkup-list-item">langN</li>
</ul></li>
</ul>

<p>so even if <tt style="background: #ebebeb; font-size: 13px;">scripts</tt> is moved \
away from SVN, the simple way to move this work again is to symlink the directory \
with the scripts as new <tt style="background: #ebebeb; font-size: \
13px;">scripts</tt> subdirectory.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R883 Subversion</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D25333">https://phabricator.kde.org/D25333</a></div></div><br \
/><div><strong>To: </strong>aspotashev, Localization, pino<br /><strong>Cc: \
</strong>pino, ltoscano, nalvarez, Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]