Giovanni did you see this? What do you think? Is there a need for having those trailing spaces? Cheers, Albert El dilluns, 25 de novembre de 2019, a les 23:48:00 CET, Adrian Chaves va es= criure: > I kept this email in my inbox to review the gl translation, which is=20 > affected. >=20 > I=E2=80=99ve just fixed the issue for gl, but it seems these files are ge= nerated=20 > from > some other source (messages/frameworks/l10n._desktop_.po?), so I assume=20 > scripty > will eventually undo my fix. >=20 > The issue seems to come from ia, where most language name translations=20 > in the > file I mentioned before have a trailing space that is not present in the= =20 > source > string. >=20 > I=E2=80=99ve taken the liberty of running the following Pology command in= the ia=20 > messages > from trunk: >=20 > posieve --skip-obsolete find-messages . -s msgid:'\S$' -s=20 > msgstr:'\s$'` >=20 > There are 1044 matches :(. But I don=E2=80=99t think it=E2=80=99s safe to= remove the=20 > spacing at > the end automatically for all those messages, because for some of them=20 > it may > be there on purpose. >=20 > There are 5 ia files with a translation of the gl language name, all of=20 > them with > an undesired trailing space, so I can probably fix the issue for gl by=20 > changing > those 5 ia messages. But I think we should try to fix it for all=20 > languages at once. >=20 > Would it be OK if I remove all trailing spaces that are not also present= =20 > in the > source message from the following files? (the ones with the issue in=20 > language > names that seem to be the source of desktop files) >=20 > messages/frameworks/l10n._desktop_.po > messages/frameworks/kdelibs4support._desktop_.po >=20 > On 2019-11-02 13:53, l10n daemon script wrote: >=20 > > Git commit 7eeab592dae4973e997c9dbd9a091068581e4a40 by l10n daemon=20 > > script. > > Committed on 02/11/2019 at 12:53. > > Pushed by dfaure into tag 'v5.64.0-rc1'. > >=20 > > GIT_SILENT Commit translations from l10n-kf5 > >=20 > > A +660 -0 po/af/kconfigwidgets5.po > > A +99 -0 po/af/kf5_entry.desktop [TRAILING SPACE] ** > > A +618 -0 po/ar/kconfigwidgets5.po > > A +99 -0 po/ar/kf5_entry.desktop [TRAILING SPACE] ** > > A +661 -0 po/as/kconfigwidgets5.po > > A +80 -0 po/as/kf5_entry.desktop [TRAILING SPACE] ** > > A +674 -0 po/be/kconfigwidgets5.po > > A +99 -0 po/be/kf5_entry.desktop [TRAILING SPACE] ** > > A +663 -0 po/be@latin/kconfigwidgets5.po > > A +84 -0 po/be@latin/kf5_entry.desktop [TRAILING SPACE] ** > > A +632 -0 po/bg/kconfigwidgets5.po > > A +99 -0 po/bg/kf5_entry.desktop [TRAILING SPACE] ** > > A +635 -0 po/bn/kconfigwidgets5.po > > A +98 -0 po/bn/kf5_entry.desktop [TRAILING SPACE] ** > > A +660 -0 po/bn_IN/kconfigwidgets5.po > > A +93 -0 po/bn_IN/kf5_entry.desktop [TRAILING SPACE] ** > > A +663 -0 po/br/kconfigwidgets5.po > > A +99 -0 po/br/kf5_entry.desktop [TRAILING SPACE] ** > > A +640 -0 po/bs/kconfigwidgets5.po > > A +77 -0 po/bs/kf5_entry.desktop > > A +94 -0 po/ca/docs/preparetips5/man-preparetips5.1.docbook > > A +629 -0 po/ca/kconfigwidgets5.po > > A +99 -0 po/ca/kf5_entry.desktop [TRAILING SPACE] ** > > A +629 -0 po/ca@valencia/kconfigwidgets5.po > > A +73 -0 po/ca@valencia/kf5_entry.desktop [TRAILING SPACE] **=20 > > [TRAILING SPACE] ** > > A +669 -0 po/crh/kconfigwidgets5.po > > A +86 -0 po/crh/kf5_entry.desktop [TRAILING SPACE] ** > > A +625 -0 po/cs/kconfigwidgets5.po > > A +99 -0 po/cs/kf5_entry.desktop [TRAILING SPACE] ** > > A +665 -0 po/csb/kconfigwidgets5.po > > A +94 -0 po/csb/kf5_entry.desktop [TRAILING SPACE] ** > > A +674 -0 po/cy/kconfigwidgets5.po > > A +99 -0 po/cy/kf5_entry.desktop [TRAILING SPACE] ** > > A +621 -0 po/da/kconfigwidgets5.po > > A +99 -0 po/da/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/de/docs/preparetips5/man-preparetips5.1.docbook > > A +628 -0 po/de/kconfigwidgets5.po > > A +99 -0 po/de/kf5_entry.desktop [TRAILING SPACE] ** > > A +637 -0 po/el/kconfigwidgets5.po > > A +99 -0 po/el/kf5_entry.desktop [TRAILING SPACE] ** > > A +620 -0 po/en_GB/kconfigwidgets5.po > > A +99 -0 po/en_GB/kf5_entry.desktop [TRAILING SPACE] ** > > A +669 -0 po/eo/kconfigwidgets5.po > > A +99 -0 po/eo/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/es/docs/preparetips5/man-preparetips5.1.docbook > > A +631 -0 po/es/kconfigwidgets5.po > > A +99 -0 po/es/kf5_entry.desktop [TRAILING SPACE] ** > > A +622 -0 po/et/kconfigwidgets5.po > > A +99 -0 po/et/kf5_entry.desktop [TRAILING SPACE] ** > > A +627 -0 po/eu/kconfigwidgets5.po > > A +99 -0 po/eu/kf5_entry.desktop [TRAILING SPACE] ** > > A +671 -0 po/fa/kconfigwidgets5.po > > A +99 -0 po/fa/kf5_entry.desktop [TRAILING SPACE] ** > > A +647 -0 po/fi/kconfigwidgets5.po > > A +99 -0 po/fi/kf5_entry.desktop [TRAILING SPACE] ** > > A +643 -0 po/fr/kconfigwidgets5.po > > A +99 -0 po/fr/kf5_entry.desktop [TRAILING SPACE] ** > > A +677 -0 po/fy/kconfigwidgets5.po > > A +97 -0 po/fy/kf5_entry.desktop [TRAILING SPACE] ** > > A +634 -0 po/ga/kconfigwidgets5.po > > A +99 -0 po/ga/kf5_entry.desktop [TRAILING SPACE] ** > > A +627 -0 po/gd/kconfigwidgets5.po > > A +629 -0 po/gl/kconfigwidgets5.po > > A +98 -0 po/gl/kf5_entry.desktop [TRAILING SPACE] ** > > A +664 -0 po/gu/kconfigwidgets5.po > > A +91 -0 po/gu/kf5_entry.desktop [TRAILING SPACE] ** > > A +637 -0 po/ha/kconfigwidgets5.po > > A +93 -0 po/ha/kf5_entry.desktop [TRAILING SPACE] ** > > A +635 -0 po/he/kconfigwidgets5.po > > A +99 -0 po/he/kf5_entry.desktop [TRAILING SPACE] ** > > A +634 -0 po/hi/kconfigwidgets5.po > > A +98 -0 po/hi/kf5_entry.desktop [TRAILING SPACE] ** > > A +666 -0 po/hne/kconfigwidgets5.po > > A +76 -0 po/hne/kf5_entry.desktop [TRAILING SPACE] ** > > A +672 -0 po/hr/kconfigwidgets5.po > > A +99 -0 po/hr/kf5_entry.desktop [TRAILING SPACE] ** > > A +670 -0 po/hsb/kconfigwidgets5.po > > A +95 -0 po/hsb/kf5_entry.desktop [TRAILING SPACE] ** > > A +619 -0 po/hu/kconfigwidgets5.po > > A +99 -0 po/hu/kf5_entry.desktop [TRAILING SPACE] ** > > A +640 -0 po/hy/kconfigwidgets5.po > > A +92 -0 po/hy/kf5_entry.desktop [TRAILING SPACE] ** > > A +621 -0 po/ia/kconfigwidgets5.po > > A +71 -0 po/ia/kf5_entry.desktop > > A +622 -0 po/id/kconfigwidgets5.po > > A +82 -0 po/id/kf5_entry.desktop [TRAILING SPACE] ** > > A +642 -0 po/is/kconfigwidgets5.po > > A +99 -0 po/is/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/it/docs/preparetips5/man-preparetips5.1.docbook > > A +631 -0 po/it/kconfigwidgets5.po > > A +99 -0 po/it/kf5_entry.desktop [TRAILING SPACE] ** > > A +649 -0 po/ja/kconfigwidgets5.po > > A +99 -0 po/ja/kf5_entry.desktop [TRAILING SPACE] ** > > A +663 -0 po/ka/kconfigwidgets5.po > > A +98 -0 po/ka/kf5_entry.desktop [TRAILING SPACE] ** > > A +635 -0 po/kk/kconfigwidgets5.po > > A +97 -0 po/kk/kf5_entry.desktop [TRAILING SPACE] ** > > A +631 -0 po/km/kconfigwidgets5.po > > A +97 -0 po/km/kf5_entry.desktop [TRAILING SPACE] ** > > A +673 -0 po/kn/kconfigwidgets5.po > > A +77 -0 po/kn/kf5_entry.desktop > > A +620 -0 po/ko/kconfigwidgets5.po > > A +99 -0 po/ko/kf5_entry.desktop [TRAILING SPACE] ** > > A +672 -0 po/ku/kconfigwidgets5.po > > A +97 -0 po/ku/kf5_entry.desktop [TRAILING SPACE] ** > > A +663 -0 po/lb/kconfigwidgets5.po > > A +97 -0 po/lb/kf5_entry.desktop [TRAILING SPACE] ** > > A +632 -0 po/lt/kconfigwidgets5.po > > A +99 -0 po/lt/kf5_entry.desktop [TRAILING SPACE] ** > > A +676 -0 po/lv/kconfigwidgets5.po > > A +99 -0 po/lv/kf5_entry.desktop > > A +673 -0 po/mai/kconfigwidgets5.po > > A +79 -0 po/mai/kf5_entry.desktop > > A +674 -0 po/mk/kconfigwidgets5.po > > A +116 -0 po/mk/kf5_entry.desktop [TRAILING SPACE] ** > > A +627 -0 po/ml/kconfigwidgets5.po > > A +90 -0 po/ml/kf5_entry.desktop > > A +633 -0 po/mr/kconfigwidgets5.po > > A +86 -0 po/mr/kf5_entry.desktop > > A +668 -0 po/ms/kconfigwidgets5.po > > A +97 -0 po/ms/kf5_entry.desktop > > A +629 -0 po/nb/kconfigwidgets5.po > > A +97 -0 po/nb/kf5_entry.desktop > > A +630 -0 po/nds/kconfigwidgets5.po > > A +96 -0 po/nds/kf5_entry.desktop > > A +670 -0 po/ne/kconfigwidgets5.po > > A +93 -0 po/ne/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/nl/docs/preparetips5/man-preparetips5.1.docbook > > A +638 -0 po/nl/kconfigwidgets5.po > > A +99 -0 po/nl/kf5_entry.desktop [TRAILING SPACE] ** > > A +624 -0 po/nn/kconfigwidgets5.po > > A +97 -0 po/nn/kf5_entry.desktop [TRAILING SPACE] ** > > A +683 -0 po/oc/kconfigwidgets5.po > > A +671 -0 po/or/kconfigwidgets5.po > > A +85 -0 po/or/kf5_entry.desktop [TRAILING SPACE] ** > > A +627 -0 po/pa/kconfigwidgets5.po > > A +98 -0 po/pa/kf5_entry.desktop [TRAILING SPACE] ** > > A +714 -0 po/pl/kconfigwidgets5.po > > A +99 -0 po/pl/kf5_entry.desktop [TRAILING SPACE] ** > > A +666 -0 po/ps/kconfigwidgets5.po > > A +83 -0 po/ps/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/pt/docs/preparetips5/man-preparetips5.1.docbook > > A +710 -0 po/pt/kconfigwidgets5.po > > A +99 -0 po/pt/kf5_entry.desktop [TRAILING SPACE] ** > > A +94 -0 po/pt_BR/docs/preparetips5/man-preparetips5.1.docbook > > A +636 -0 po/pt_BR/kconfigwidgets5.po > > A +98 -0 po/pt_BR/kf5_entry.desktop > > A +630 -0 po/ro/kconfigwidgets5.po > > A +99 -0 po/ro/kf5_entry.desktop > > A +92 -0 po/ru/docs/preparetips5/man-preparetips5.1.docbook > > A +642 -0 po/ru/kconfigwidgets5.po > > A +101 -0 po/ru/kf5_entry.desktop > > A +624 -0 po/se/kconfigwidgets5.po > > A +100 -0 po/se/kf5_entry.desktop > > A +664 -0 po/si/kconfigwidgets5.po > > A +78 -0 po/si/kf5_entry.desktop > > A +628 -0 po/sk/kconfigwidgets5.po > > A +93 -0 po/sk/kf5_entry.desktop [TRAILING SPACE] ** > > A +634 -0 po/sl/kconfigwidgets5.po > > A +99 -0 po/sl/kf5_entry.desktop > > A +657 -0 po/sq/kconfigwidgets5.po > > A +76 -0 po/sq/kf5_entry.desktop [TRAILING SPACE] ** > > A +625 -0 po/sr/kconfigwidgets5.po > > A +99 -0 po/sr/kf5_entry.desktop > > A +624 -0 po/sr@ijekavian/kconfigwidgets5.po > > A +70 -0 po/sr@ijekavian/kf5_entry.desktop [TRAILING SPACE] ** > > A +624 -0 po/sr@ijekavianlatin/kconfigwidgets5.po > > A +70 -0 po/sr@ijekavianlatin/kf5_entry.desktop > > A +624 -0 po/sr@latin/kconfigwidgets5.po > > A +97 -0 po/sr@latin/kf5_entry.desktop > > A +94 -0 po/sv/docs/preparetips5/man-preparetips5.1.docbook > > A +630 -0 po/sv/kconfigwidgets5.po > > A +99 -0 po/sv/kf5_entry.desktop > > A +669 -0 po/ta/kconfigwidgets5.po > > A +99 -0 po/ta/kf5_entry.desktop > > A +636 -0 po/te/kconfigwidgets5.po > > A +96 -0 po/te/kf5_entry.desktop > > A +625 -0 po/tg/kconfigwidgets5.po > > A +98 -0 po/tg/kf5_entry.desktop > > A +672 -0 po/th/kconfigwidgets5.po > > A +99 -0 po/th/kf5_entry.desktop > > A +637 -0 po/tr/kconfigwidgets5.po > > A +99 -0 po/tr/kf5_entry.desktop > > A +669 -0 po/tt/kconfigwidgets5.po > > A +72 -0 po/tt/kf5_entry.desktop > > A +630 -0 po/ug/kconfigwidgets5.po > > A +69 -0 po/ug/kf5_entry.desktop > > A +94 -0 po/uk/docs/preparetips5/man-preparetips5.1.docbook > > A +627 -0 po/uk/kconfigwidgets5.po > > A +99 -0 po/uk/kf5_entry.desktop > > A +656 -0 po/uz/kconfigwidgets5.po > > A +97 -0 po/uz/kf5_entry.desktop > > A +661 -0 po/uz@cyrillic/kconfigwidgets5.po > > A +89 -0 po/uz@cyrillic/kf5_entry.desktop > > A +670 -0 po/vi/kconfigwidgets5.po > > A +99 -0 po/vi/kf5_entry.desktop > > A +670 -0 po/wa/kconfigwidgets5.po > > A +98 -0 po/wa/kf5_entry.desktop > > A +653 -0 po/xh/kconfigwidgets5.po > > A +98 -0 po/xh/kf5_entry.desktop > > A +629 -0 po/zh_CN/kconfigwidgets5.po > > A +99 -0 po/zh_CN/kf5_entry.desktop > > A +687 -0 po/zh_HK/kconfigwidgets5.po > > A +95 -0 po/zh_HK/kf5_entry.desktop [TRAILING SPACE] ** > > A +627 -0 po/zh_TW/kconfigwidgets5.po > > A +77 -0 po/zh_TW/kf5_entry.desktop [TRAILING SPACE] ** > >=20 > > The files marked with ** at the end have a problem. either the file=20 > > contains a trailing space or the file contains a call to a potentially= =20 > > dangerous code. Please read:=20 > > http://community.kde.org/Sysadmin/CommitHooks#Email_notifications=20 > > Either fix the trailing space or review the dangerous code. > >=20 > > https://commits.kde.org/kconfigwidgets/7eeab592dae4973e997c9dbd9a091068= 581e4a40 >=20