[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: T11721: Splitting of i18n strings
From: Roman Gilg <noreply () phabricator ! kde ! org>
Date: 2019-09-24 8:13:50
Message-ID: 8be357f18cf2f34b0e1c5561eb068717 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
romangg added a comment.
In T11721#202182 <https://phabricator.kde.org/T11721#202182>, @pino wrote:
> > ! In T11721#202172 <https://phabricator.kde.org/T11721#202172>, @aacid wrote:
> > FWIW you can do
> >
> > text: i18n("bla \
> > hola")
> >
> >
> > and it will work, but note the hola needs to start at column 0, probably your \
strict code style doesn't allow for that either. >
> This was suggested: https://phabricator.kde.org/D23783#527600
> ... and not accepted by the maintainer either because "ugly".
The reason I gave in what you cited was what @aacid already noted as well: that the \
indent can't be chosen arbitrary. To expand on that: since the strings are normally \
embedded into other controls, often in declarative QML having several levels of \
indent, I would like to avoid this.
I find it disingenuous to leave me mentioning the indent out from what you quoted \
making my opinion look overly subjective. If we want to work on this issue, we should \
be fair to each other.
There is also another reason for not using these multi-line strings with `\`: they \
are not recommended in JavaScript. Either `+` should be used or back-tick multiline \
strings (these again don't respect the indent though).
TASK DETAIL
https://phabricator.kde.org/T11721
To: romangg
Cc: aacid, Nemo_bis, mart, pino, ltoscano, aspotashev, kde-i18n-doc, romangg, \
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, sdepiets, \
dkardarakos, ZrenBot, alexeymin, skadinna, himcesjf, huftis, pshinjo, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, hein
[Attachment #3 (text/html)]
<table><tr><td style="">romangg added a comment.
</td></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/T11721#202182" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T11721#202182</a>, <a \
href="https://phabricator.kde.org/p/pino/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@pino</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>! In <a \
href="https://phabricator.kde.org/T11721#202172" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T11721#202172</a>, <a \
href="https://phabricator.kde.org/p/aacid/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> wrote:<br />
FWIW you can do</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"> text: i18n("bla \ \
hola")</pre></div>
<p>and it will work, but note the hola needs to start at column 0, probably your \
strict code style doesn't allow for that either.</p></blockquote>
<p>This was suggested: <a href="https://phabricator.kde.org/D23783#527600" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D23783#527600</a><br />
... and not accepted by the maintainer either because "ugly".</p></div>
</blockquote>
<p>The reason I gave in what you cited was what <a \
href="https://phabricator.kde.org/p/aacid/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> already noted as well: that the indent \
can't be chosen arbitrary. To expand on that: since the strings are normally \
embedded into other controls, often in declarative QML having several levels of \
indent, I would like to avoid this.</p>
<p>I find it disingenuous to leave me mentioning the indent out from what you quoted \
making my opinion look overly subjective. If we want to work on this issue, we should \
be fair to each other.</p>
<p>There is also another reason for not using these multi-line strings with <tt \
style="background: #ebebeb; font-size: 13px;">\</tt>: they are not recommended in \
JavaScript. Either <tt style="background: #ebebeb; font-size: 13px;">+</tt> should be \
used or back-tick multiline strings (these again don't respect the indent \
though).</p></div></div><br /><div><strong>TASK DETAIL</strong><div><a \
href="https://phabricator.kde.org/T11721">https://phabricator.kde.org/T11721</a></div></div><br \
/><div><strong>To: </strong>romangg<br /><strong>Cc: </strong>aacid, Nemo_bis, mart, \
pino, ltoscano, aspotashev, kde-i18n-doc, romangg, LeGast00n, The-Feren-OS-Dev, \
jraleigh, fbampaloukas, GB_2, ragreen, domson, sdepiets, dkardarakos, ZrenBot, \
alexeymin, skadinna, himcesjf, huftis, pshinjo, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, davidedmundson, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic