[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D23953: Warn before opening 5+ translation files
From:       Yi-Jyun Pan <noreply () phabricator ! kde ! org>
Date:       2019-09-15 9:16:38
Message-ID: 7f32172c8a5d75ed20b42234891cd6dd () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ppeter requested changes to this revision.
ppeter added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> projecttab.cpp:354
> +    if (i > 5) {
> +        QString question = i18np("Are you sure you want to open 1 item?", "Are you \
> sure you want to open %1 items?", i); +        const int answer = \
> KMessageBox::warningYesNo(this, question);

I think that is better to add the reason why the warning appears.

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D23953

To: adrianchavesfernandez, #localization, ppeter
Cc: ppeter


[Attachment #3 (text/html)]

<table><tr><td style="">ppeter requested changes to this revision.<br />ppeter added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23953">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D23953#inline-135565">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">projecttab.cpp:354</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">i</span> <span style="color: \
#aa2211">&gt;</span> <span style="color: #601200">5</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">QString</span> <span \
class="n">question</span> <span style="color: #aa2211">=</span> <span \
class="n">i18np</span><span class="p">(</span><span style="color: #766510">&quot;Are \
you sure you want to open 1 item?&quot;</span><span class="p">,</span> <span \
style="color: #766510">&quot;Are you sure you want to open %1 \
items?&quot;</span><span class="p">,</span> <span class="n">i</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span \
style="color: #aa4000">int</span> <span class="n">answer</span> <span style="color: \
#aa2211">=</span> <span class="n">KMessageBox</span><span style="color: \
#aa2211">::</span><span class="n">warningYesNo</span><span class="p">(</span><span \
style="color: #aa4000">this</span><span class="p">,</span> <span \
class="n">question</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
think that is better to add the reason why the warning \
appears.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D23953">https://phabricator.kde.org/D23953</a></div></div><br \
/><div><strong>To: </strong>adrianchavesfernandez, Localization, ppeter<br \
/><strong>Cc: </strong>ppeter<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]