[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D21956: Move class ColorOptionParser into separate file
From:       Chusslove Illich <noreply () phabricator ! kde ! org>
Date:       2019-06-21 11:39:12
Message-ID: 64d9ae4b0fc227b28771a5f7e56404d6 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ilic added a comment.


  I don't agree that ColorOptionParser should not be part of Pology public API. \
Someone might want to write a custom command that uses Pology, without contributing \
it Pology repository. Or, in other words, if ColorString is part of API and returned \
by Pology's Gettext wrappers, then ColorOptionParser should be too.

REPOSITORY
  R1046 Pology

REVISION DETAIL
  https://phabricator.kde.org/D21956

To: aspotashev, ilic
Cc: #localization


[Attachment #3 (text/html)]

<table><tr><td style="">ilic added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D21956">View Revision</a></tr></table><br \
/><div><div><p>I don&#039;t agree that ColorOptionParser should not be part of Pology \
public API. Someone might want to write a custom command that uses Pology, without \
contributing it Pology repository. Or, in other words, if ColorString is part of API \
and returned by Pology&#039;s Gettext wrappers, then ColorOptionParser should be \
too.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R1046 \
Pology</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21956">https://phabricator.kde.org/D21956</a></div></div><br \
/><div><strong>To: </strong>aspotashev, ilic<br /><strong>Cc: \
</strong>Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]