[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D21777: Display only icons in column "Translation Status"
From:       Alexander Potashev <noreply () phabricator ! kde ! org>
Date:       2019-06-13 0:47:24
Message-ID: f36fd1a51f11fa09c459ad59f3cdd9a0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aspotashev created this revision.
aspotashev added reviewers: sdepiets, aacid.
aspotashev requested review of this revision.

REVISION SUMMARY
  catalogmodel: Convert enum CatalogModelColumns to enum class
  
  catalogmodel: Factorize calculation of translation status into CatalogTreeModel::getTranslationStatus()
  
  catalogmodel: Display only icons in column "Translation Status"
  
  This lets the user save some screen space by shrinking this column.
  
  catalogmodel: Fix compiler warnings about incomplete switch operator

TEST PLAN
  Manually tested:
  
  1. contents of column "Translation Status" with Russian digikam.po where we have all 3 statuses;
  2. new tooltips;
  3. sorting by column "Translation Status".

REPOSITORY
  R456 Lokalize

BRANCH
  status-icons

REVISION DETAIL
  https://phabricator.kde.org/D21777

AFFECTED FILES
  src/cataloglistview/catalogmodel.cpp
  src/cataloglistview/catalogmodel.h

To: aspotashev, sdepiets, aacid
Cc: kde-i18n-doc

[Attachment #3 (text/html)]

<table><tr><td style="">aspotashev created this revision.<br />aspotashev added \
reviewers: sdepiets, aacid.<br />aspotashev requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D21777">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>catalogmodel: Convert enum \
CatalogModelColumns to enum class</p>

<p>catalogmodel: Factorize calculation of translation status into \
CatalogTreeModel::getTranslationStatus()</p>

<p>catalogmodel: Display only icons in column &quot;Translation Status&quot;</p>

<p>This lets the user save some screen space by shrinking this column.</p>

<p>catalogmodel: Fix compiler warnings about incomplete switch \
operator</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Manually \
tested:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">contents of column &quot;Translation Status&quot; with \
Russian digikam.po where we have all 3 statuses;</li> <li \
class="remarkup-list-item">new tooltips;</li> <li class="remarkup-list-item">sorting \
by column &quot;Translation Status&quot;.</li> </ol></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>status-icons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D21777">https://phabricator.kde.org/D21777</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/cataloglistview/catalogmodel.cpp<br /> \
src/cataloglistview/catalogmodel.h</div></div></div><br /><div><strong>To: \
</strong>aspotashev, sdepiets, aacid<br /><strong>Cc: </strong>kde-i18n-doc<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]