[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Cannot update strings of Kdenlive (blocked by pre-commit hook)
From:       Shinjo Park <kde () peremen ! name>
Date:       2019-05-19 19:00:47
Message-ID: 1689170.hiTDjvNeck () ainazi
[Download RAW message or body]

2019년 5월 19일 일요일 오후 6시 6분 42초 CEST에 Luigi Toscano 님이 쓴 글:
> Shinjo Park ha scritto:
> > Hi,
> > 
> > While I tried to commit the new strings of Kdenlive I found pre-commit
> > hooks are incorrectly working. For translations of unicodedialog.cpp, I
> > changed English Wikipedia URL into Korean counterpart like this:
> > 
> > #: src/titler/unicodedialog.cpp:146
> > #, kde-format
> > msgid ""
> > "Control character. Cannot be inserted/printed. See <a href=\"http://en."
> > "wikipedia.org/wiki/Control_character\">Wikipedia:Control_character</a>"
> > msgstr ""
> > "� �어 문자이므로 삽입하거나 출� ��  수 없습니다. 참조: <a href=\"https://ko."
> > "wikipedia.org/wiki/%EC%A0%9C%EC%96%B4_%EB%AC%B8%EC%9E%90\">위키백과: � �어 "
> > "문자</a>"
> > 
> > And the pre-commit hook blocks these URLs to be committed:
> > 
> > svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
> > <stdin>:11605: 'msgstr' is not a valid KDE format string, unlike 'msgid'.
> > Reason: The string refers to argument number 9 but ignores the arguments 1
> > and 2.
> > ... same error pops again
> > 
> > Well, those URLs indeed contains "%9" as this is a percent encoded string.
> > However, this has nothing to do with format arguments. What should I do?
> 
> The pre-commit hook just use msgfmt, so even if the check is removed,
> something else is going to fail somewhere. As it has been suggested,
> couldn't you write the non-encoded version of the URL, by using the full
> set of UTF-8 characters?
> 
> Ciao

Okay, that makes sense. I would prefer to use only ASCII characters for 
machine-facing URLs, but utilizing full UTF-8 characters is not a problem.



[prev in list] [next in list] [prev in thread] [next in thread]