[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D19114: Fix bug not finding local document
From:       Ralf Habacker <noreply () phabricator ! kde ! org>
Date:       2019-03-27 17:20:43
Message-ID: f22efb344396841ab3401f6600697c6a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

habacker added a comment.


  In D19114#439378 <https://phabricator.kde.org/D19114#439378>, @sdepiets wrote:
  
  > - First of all I see in your screenshot you're trying to open an .xml file.
  
  
  In the review request I wrote that I used a cpp file, not an xml file.  I linked to \
an available screenshot to show the related dock window. :-)  
  >   those files are not indexed. See src/project/project.cpp
  
  This means that xml files and other file types that are not included in the filter \
are not accessible without this patch (and with this patch, but editor support not \
enabled )?  
  Does this result in an error message that this file type is not supported? If not, \
I think a little more work is needed here to inform the user.

REPOSITORY
  R456 Lokalize

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19114

To: habacker, #localization, sdepiets
Cc: adrianchavesfernandez, aacid


[Attachment #3 (text/html)]

<table><tr><td style="">habacker added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D19114">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D19114#439378" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D19114#439378</a>, <a \
href="https://phabricator.kde.org/p/sdepiets/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@sdepiets</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><ul class="remarkup-list">
<li class="remarkup-list-item">First of all I see in your screenshot you&#039;re \
trying to open an .xml file.</li> </ul></div>
</blockquote>

<p>In the review request I wrote that I used a cpp file, not an xml file.  I linked \
to an available screenshot to show the related dock window. :-)</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">those files are not indexed. \
See src/project/project.cpp</pre></div></blockquote>

<p>This means that xml files and other file types that are not included in the filter \
are not accessible without this patch (and with this patch, but editor support not \
enabled )?</p>

<p>Does this result in an error message that this file type is not supported? If not, \
I think a little more work is needed here to inform the user.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D19114">https://phabricator.kde.org/D19114</a></div></div><br \
/><div><strong>To: </strong>habacker, Localization, sdepiets<br /><strong>Cc: \
</strong>adrianchavesfernandez, aacid<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]