[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D18693: Add support for viewing the translation source with a custom editor
From:       Simon Depiets <noreply () phabricator ! kde ! org>
Date:       2019-02-05 4:47:20
Message-ID: 68e215c88bd3e278088d1e616e4cc849 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sdepiets added inline comments.

INLINE COMMENTS

> ppeter wrote in prefs_general.ui:84
> I think those strings need to be translatable... I had read \
> https://techbase.kde.org/Development/Tutorials/Localization/i18n and didn't see any \
> I18N function here. 
> If the strings is translatable but I don't know, just ignore it ;)

Strings in ui files are automatically picked up for translation so this is not an \
issue.

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D18693

To: habacker, sdepiets, #localization, ppeter
Cc: ppeter


[Attachment #3 (text/html)]

<table><tr><td style="">sdepiets added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D18693">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D18693#inline-104072">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ppeter</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">prefs_general.ui:84</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I think \
those strings need to be translatable... I had read <a \
href="https://techbase.kde.org/Development/Tutorials/Localization/i18n" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://techbase.kde.org/Development/Tutorials/Localization/i18n</a> \
and didn&#039;t see any I18N function here.</p>

<p style="padding: 0; margin: 8px;">If the strings is translatable but I don&#039;t \
know, just ignore it ;)</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Strings in ui files are automatically \
picked up for translation so this is not an \
issue.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D18693">https://phabricator.kde.org/D18693</a></div></div><br \
/><div><strong>To: </strong>habacker, sdepiets, Localization, ppeter<br /><strong>Cc: \
</strong>ppeter<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]