[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D17739: Add a po file for the list of words in GCompris
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2019-01-20 15:30:42
Message-ID: 32603c6cf64b8e616c400c295e1ddf68 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix added a comment.


  In D17739#396953 <https://phabricator.kde.org/D17739#396953>, @huftis wrote:
  
  > I have tested the scripts and found one bug in `poToDataset.py`. It also converts \
**obsolete** entries in the PO file into JSON entries.  >
  > But I have a question. Is it //necessary// to also output the empty \
(untranslated/fuzzy) entries? If not, you can fix the bug and simplify the JSON files \
at the same time by just using:  >
  >   for entry in poFile.translated_entries():
  >       word = entry.msgctxt
  >       data[word] = entry.msgstr
  
  
  It will work (I tried by removing all numbers of the json file excepting 2) and
  
  In D17739#396971 <https://phabricator.kde.org/D17739#396971>, @huftis wrote:
  
  > I don't know how `StaticMessages.sh` stuff works, so I'm not qualified to test \
that part. But I've tested the POT and JSON generator scripts, and they seem to work \
perfectly.  >
  > Thanks your work on this! It make the translators' work much easier.
  
  
  Thank you a lot for all the remarks! (Albert and Pino too :)). I'm pushing it and \
I'll check the logs tomorrow and merge the existing translations. If good, I'll \
uncomment the import

REVISION DETAIL
  https://phabricator.kde.org/D17739

To: jjazeix, #gcompris, #localization, huftis
Cc: pino, huftis, aacid, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, \
echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, \
bcoudoin


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17739">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D17739#396953" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D17739#396953</a>, <a \
href="https://phabricator.kde.org/p/huftis/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@huftis</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I have tested the scripts and found one bug \
in <tt style="background: #ebebeb; font-size: 13px;">poToDataset.py</tt>. It also \
converts <strong>obsolete</strong> entries in the PO file into JSON entries.</p>

<p>But I have a question. Is it <em>necessary</em> to also output the empty \
(untranslated/fuzzy) entries? If not, you can fix the bug and simplify the JSON files \
at the same time by just using:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for entry in \
poFile.translated_entries():  word = entry.msgctxt
    data[word] = entry.msgstr</pre></div></div>
</blockquote>

<p>It will work (I tried by removing all numbers of the json file excepting 2) \
and</p>

<blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D17739#396971" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D17739#396971</a>, <a \
href="https://phabricator.kde.org/p/huftis/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@huftis</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I don't know how <tt style="background: \
#ebebeb; font-size: 13px;">StaticMessages.sh</tt> stuff works, so I'm not qualified \
to test that part. But I've tested the POT and JSON generator scripts, and they seem \
to work perfectly.</p>

<p>Thanks your work on this! It make the translators' work much easier.</p></div>
</blockquote>

<p>Thank you a lot for all the remarks! (Albert and Pino too :)). I&#039;m pushing it \
and I&#039;ll check the logs tomorrow and merge the existing translations. If good, \
I&#039;ll uncomment the import</p></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17739">https://phabricator.kde.org/D17739</a></div></div><br \
/><div><strong>To: </strong>jjazeix, GCompris, Localization, huftis<br /><strong>Cc: \
</strong>pino, huftis, aacid, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, \
echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, \
bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]