[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D15759: Add new ways to launch pology on file(s)
From:       Laurent Montel <noreply () phabricator ! kde ! org>
Date:       2018-09-29 8:10:52
Message-ID: 50924617bec51c9f45d25aa30f81919f () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Otherwise all seems ok for me.

INLINE COMMENTS

> editortab.cpp:1406
> +    QString command = \
> Settings::self()->pologyCommandFile().replace(QStringLiteral("%f"), \
> QStringLiteral("\"") + currentFilePath() + QStringLiteral("\"")); +    \
> m_pologyProcess = new KProcess; +    \
> m_pologyProcess->setOutputChannelMode(KProcess::SeparateChannels);

Potential mem leak no ?
Where this KProcess is deleted ?

perhaps add (this) no ?

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D15759

To: sdepiets, #localization, aacid, adrianchavesfernandez, huftis, mlaurent
Cc: mlaurent, michaldybczak, sdepiets, skadinna, huftis


[Attachment #3 (text/html)]

<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15759">View \
Revision</a></tr></table><br /><div><div><p>Otherwise all seems ok for \
me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15759#inline-85639">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">editortab.cpp:1406</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span \
class="n">command</span> <span style="color: #aa2211">=</span> <span \
class="n">Settings</span><span style="color: #aa2211">::</span><span \
class="n">self</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">pologyCommandFile</span><span \
class="p">().</span><span class="n">replace</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">&quot;%f&quot;</span><span class="p">),</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">&quot;</span><span style="color: #bb6622">\&quot;</span><span style="color: \
#766510">&quot;</span><span class="p">)</span> <span style="color: #aa2211">+</span> \
<span class="n">currentFilePath</span><span class="p">()</span> <span style="color: \
#aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">&quot;</span><span style="color: #bb6622">\&quot;</span><span \
style="color: #766510">&quot;</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">m_pologyProcess</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa4000">new</span> <span class="n">KProcess</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">m_pologyProcess</span><span \
style="color: #aa2211">-&gt;</span><span class="n">setOutputChannelMode</span><span \
class="p">(</span><span class="n">KProcess</span><span style="color: \
#aa2211">::</span><span class="n">SeparateChannels</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Potential mem leak no ?<br /> Where this KProcess is deleted ?</p>

<p style="padding: 0; margin: 8px;">perhaps add (this) no \
?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15759">https://phabricator.kde.org/D15759</a></div></div><br \
/><div><strong>To: </strong>sdepiets, Localization, aacid, adrianchavesfernandez, \
huftis, mlaurent<br /><strong>Cc: </strong>mlaurent, michaldybczak, sdepiets, \
skadinna, huftis<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]