[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D15181: Add basic pology posieve request support
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-08-31 20:18:53
Message-ID: 248193fa569c33413dc7332cfd4b94b1 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added inline comments.

INLINE COMMENTS

> msgctxtview.cpp:220
> +        addTemporaryEntryNote(m_entry.entry, m_pologyData);
> +    }
> +}

You should call delete/deleteLater on m_pologyProcess here

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D15181

To: sdepiets, #localization, aacid, ltoscano, mlaurent
Cc: #localization

[Attachment #3 (text/html)]

<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15181">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15181#inline-81464">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">msgctxtview.cpp:220</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">addTemporaryEntryNote</span><span class="p">(</span><span \
class="n">m_entry</span><span class="p">.</span><span class="n">entry</span><span \
class="p">,</span> <span class="n">m_pologyData</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
should call delete/deleteLater on m_pologyProcess \
here</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15181">https://phabricator.kde.org/D15181</a></div></div><br \
/><div><strong>To: </strong>sdepiets, Localization, aacid, ltoscano, mlaurent<br \
/><strong>Cc: </strong>Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]