[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D15049: Fix project model issues on file changes
From:       Simon Depiets <noreply () phabricator ! kde ! org>
Date:       2018-08-29 2:06:06
Message-ID: 39ea41a62bf21b020fcb60696e8ff5f0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sdepiets marked 2 inline comments as done.
sdepiets added inline comments.

INLINE COMMENTS

> aacid wrote in projectmodel.cpp:1098
> since you're moving it and causing a diff, make it const, makes reading the rest of \
> the code easier not having to worry if it's going to change or not.

understood, I'll try to remember to do that going forward

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D15049

To: sdepiets, ltoscano, #localization, aacid, mlaurent
Cc: michaldybczak, sdepiets, skadinna, huftis


[Attachment #3 (text/html)]

<table><tr><td style="">sdepiets marked 2 inline comments as done.<br />sdepiets \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15049">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15049#inline-81043">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">aacid</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">projectmodel.cpp:1098</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">since \
you&#039;re moving it and causing a diff, make it const, makes reading the rest of \
the code easier not having to worry if it&#039;s going to change or \
not.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">understood, I&#039;ll try to remember to do that going \
forward</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15049">https://phabricator.kde.org/D15049</a></div></div><br \
/><div><strong>To: </strong>sdepiets, ltoscano, Localization, aacid, mlaurent<br \
/><strong>Cc: </strong>michaldybczak, sdepiets, skadinna, huftis<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]