[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D15109: Improve management of empty/invalid files
From: Albert Astals Cid <noreply () phabricator ! kde ! org>
Date: 2018-08-28 20:50:38
Message-ID: f0c0ee84b72cb955ff4bfec16ca0a309 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
aacid added inline comments.
INLINE COMMENTS
> projectmodel.cpp:633
> int untranslated = node->untranslated;
> - bool hasStats = translated != -1;
> + bool invalid_file = node->invalid_file;
> + bool hasStats = translated != -1 || invalid_file;
const here and below?
> projectmodel.cpp:1315
> s >> d.sourceDate;
> + s >> d.invalid_file;
> return s;
I've no idea what this operator is for, but if it's used to store to disk, do we need \
versioning here? So we can read old and new versions?
REPOSITORY
R456 Lokalize
REVISION DETAIL
https://phabricator.kde.org/D15109
To: sdepiets, ltoscano, aacid, mlaurent, #localization
Cc: michaldybczak, sdepiets, skadinna, huftis
[Attachment #3 (text/html)]
<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15109">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15109#inline-81045">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">projectmodel.cpp:633</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">int</span> \
<span class="n">untranslated</span> <span style="color: #aa2211">=</span> <span \
class="n">node</span><span style="color: #aa2211">-></span><span \
class="n">untranslated</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: \
#aa4000">bool</span> <span class="bright"></span><span class="n"><span \
class="bright">hasStats</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">=</span></span><span class="bright"> </span><span \
class="n"><span class="bright">translated</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">!=</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">-</span></span><span class="bright"></span><span style="color: \
#601200"><span class="bright">1</span></span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">bool</span> <span class="bright"></span><span class="n"><span \
class="bright">invalid_file</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">node</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">invalid_file</span></span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">bool</span> <span class="n">hasStats</span> <span \
style="color: #aa2211">=</span> <span class="n">translated</span> <span style="color: \
#aa2211">!=</span> <span style="color: #aa2211">-</span><span style="color: \
#601200">1</span> <span style="color: #aa2211">||</span> <span \
class="n">invalid_file</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">const here and below?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15109#inline-81044">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">projectmodel.cpp:1315</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span class="n">s</span> <span \
style="color: #aa2211">>></span> <span class="n">d</span><span \
class="p">.</span><span class="n">sourceDate</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">s</span> <span style="color: #aa2211">>></span> <span \
class="n">d</span><span class="p">.</span><span class="n">invalid_file</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; "> <span \
style="color: #aa4000">return</span> <span class="n">s</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I've no idea what this operator is for, but if it's used to \
store to disk, do we need versioning here? So we can read old and new \
versions?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15109">https://phabricator.kde.org/D15109</a></div></div><br \
/><div><strong>To: </strong>sdepiets, ltoscano, aacid, mlaurent, Localization<br \
/><strong>Cc: </strong>michaldybczak, sdepiets, skadinna, huftis<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic