[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D14854: Switch to the new connect() API
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-08-15 8:39:11
Message-ID: 0c61797dd5823bdfa8a98d3e40ae7505 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
broulik added inline comments.
INLINE COMMENTS
> alttransview.cpp:83
> {
> - connect(m_actions.at(i),SIGNAL(triggered()),signalMapper,SLOT(map()));
> + connect(m_actions.at(i), &QAction::triggered, signalMapper, \
> QOverload<>::of(&QSignalMapper::map)); signalMapper->setMapping(m_actions.at(i), \
> i);
When you can use lambdas, you also don't really need `QSignalMapper` since you can \
just capture the actual `QAction`. But this could/should be done in a separate patch.
REPOSITORY
R456 Lokalize
REVISION DETAIL
https://phabricator.kde.org/D14854
To: sdepiets, #localization, aacid, ltoscano, shaforostoff, mlaurent
Cc: broulik, michaldybczak, sdepiets, skadinna, huftis
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14854">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14854#inline-78789">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">alttransview.cpp:83</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span class="n">connect</span><span class="p">(</span><span \
class="n">m_actions</span><span class="p">.</span><span class="n">at</span><span \
class="p">(</span><span class="n">i</span><span class="p">),<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">SIGNAL</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="n">triggered<span \
class="bright"></span></span><span class="bright"></span><span class="p"><span \
class="bright">()),</span></span><span class="n">signalMapper</span><span \
class="p">,<span class="bright"></span></span><span class="bright"></span><span \
class="n"><span class="bright">SLOT</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">map</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>));</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">connect</span><span class="p">(</span><span class="n">m_actions</span><span \
class="p">.</span><span class="n">at</span><span class="p">(</span><span \
class="n">i</span><span class="p">),<span class="bright"></span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">&</span></span><span class="bright"></span><span class="n"><span \
class="bright">QAction</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">::</span></span><span class="n">triggered<span \
class="bright"></span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span \
class="n">signalMapper</span><span class="p">,<span \
class="bright"></span></span><span class="bright"> </span><span class="n"><span \
class="bright">QOverload</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright"><>::</span></span><span \
class="bright"></span><span class="n"><span class="bright">of</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">&</span></span><span class="bright"></span><span class="n"><span \
class="bright">QSignalMapper</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span class="bright">map</span></span><span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="n">signalMapper</span><span style="color: #aa2211">-></span><span \
class="n">setMapping</span><span class="p">(</span><span \
class="n">m_actions</span><span class="p">.</span><span class="n">at</span><span \
class="p">(</span><span class="n">i</span><span class="p">),</span> <span \
class="n">i</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">When \
you can use lambdas, you also don't really need <tt style="background: #ebebeb; \
font-size: 13px;">QSignalMapper</tt> since you can just capture the actual <tt \
style="background: #ebebeb; font-size: 13px;">QAction</tt>. But this could/should be \
done in a separate patch.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14854">https://phabricator.kde.org/D14854</a></div></div><br \
/><div><strong>To: </strong>sdepiets, Localization, aacid, ltoscano, shaforostoff, \
mlaurent<br /><strong>Cc: </strong>broulik, michaldybczak, sdepiets, skadinna, \
huftis<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic