[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D14177: Fix drag'n'drop behavior within the Target area
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-07-29 21:36:50
Message-ID: dd4381b790c6bd0c32f13d319451a31f () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added a comment.


  I would feel more safe if you initialized  m_cursorSelectionStart and \
m_cursorSelectionEnd to 0 in the constructor  
  Also do you know why we need this custom implementation of the drag and drop of \
text? I mean in a regular TextEdit the drag and drop "just works" so why do we need \
this stuff by ourselves? Would removing code instead of adding be possible?

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D14177

To: sdepiets, #localization, aacid, ltoscano, shaforostoff, mlaurent
Cc: michaldybczak, sdepiets, skadinna, huftis


[Attachment #3 (text/html)]

<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14177">View Revision</a></tr></table><br \
/><div><div><p>I would feel more safe if you initialized  m_cursorSelectionStart and \
m_cursorSelectionEnd to 0 in the constructor</p>

<p>Also do you know why we need this custom implementation of the drag and drop of \
text? I mean in a regular TextEdit the drag and drop &quot;just works&quot; so why do \
we need this stuff by ourselves? Would removing code instead of adding be \
possible?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R456 \
Lokalize</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14177">https://phabricator.kde.org/D14177</a></div></div><br \
/><div><strong>To: </strong>sdepiets, Localization, aacid, ltoscano, shaforostoff, \
mlaurent<br /><strong>Cc: </strong>michaldybczak, sdepiets, skadinna, huftis<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic