[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D14219: Add a feature to hide translated files on the Project tab
From: Simon Depiets <noreply () phabricator ! kde ! org>
Date: 2018-07-24 1:37:37
Message-ID: 37d282c712a2e23e34e5544a9c1cf056 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
sdepiets marked an inline comment as done.
sdepiets added inline comments.
INLINE COMMENTS
> aacid wrote in projectmanagerui.rc:17
> Why is this on the "Go" menu instead of on the "Settings" menu? To me it seems it \
> would make more sense in settings.
ok, it could be in Project as well, I don't have a strong preference on this one so \
I'll follow your advice.
> aacid wrote in projecttab.cpp:183
> it also hides folders, though adding it probably makes it too long (at least for \
> the toolbar).
> I think there's two ways
>
> a)
> action->setText(i18nc("@action:inmenu","Hide fully translated files and folders"));
> action->setIconText(i18nc("@action:inmenu","Hide fully translated files"));
>
> This way the toolbar doesn't have the "and folders" but the menu does, saves some \
> space on the toolbar but not on the menu since on the menu is less needed (though \
> it can be a bit confusing to users the fact that there's two different texts for \
> the same action)
> b)
> action->setText(i18nc("@action:inmenu","Hide fully translated files"));
> action->setToolTip(i18nc("@action:inmenu","Hide fully translated files and \
> folders"));
> So the tooltip on the toolbar gives some more info.
>
> What do you think? Or am i making a big deal of nothing? 😄
Why not both ?
I was thinking of something like "items" instead of "files and folders" but it would \
be more confusing, some people may think it would hide the translated strings within \
the files.
REPOSITORY
R456 Lokalize
REVISION DETAIL
https://phabricator.kde.org/D14219
To: sdepiets, aacid, #localization, ltoscano, shaforostoff, mlaurent, huftis
Cc: schwarzer, huftis, michaldybczak, sdepiets, skadinna
[Attachment #3 (text/html)]
<table><tr><td style="">sdepiets marked an inline comment as done.<br />sdepiets \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14219">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14219#inline-75364">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">aacid</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">projectmanagerui.rc:17</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Why is \
this on the "Go" menu instead of on the "Settings" menu? To me it \
seems it would make more sense in settings.</p></div></div> <div style="margin: 8px \
0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ok, it could be in Project \
as well, I don't have a strong preference on this one so I'll follow your \
advice.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14219#inline-75366">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">aacid</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">projecttab.cpp:183</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">it also hides folders, though adding it probably makes it too long (at least \
for the toolbar).</p>
<p style="padding: 0; margin: 8px;">I think there's two ways</p>
<p style="padding: 0; margin: 8px;">a)<br />
action->setText(i18nc("<span \
class="phabricator-remarkup-mention-unknown">@action</span>:inmenu","Hide \
fully translated files and folders"));<br /> \
action->setIconText(i18nc("<span \
class="phabricator-remarkup-mention-unknown">@action</span>:inmenu","Hide \
fully translated files"));</p>
<p style="padding: 0; margin: 8px;">This way the toolbar doesn't have the \
"and folders" but the menu does, saves some space on the toolbar but not on \
the menu since on the menu is less needed (though it can be a bit confusing to users \
the fact that there's two different texts for the same action)</p>
<p style="padding: 0; margin: 8px;">b)<br />
action->setText(i18nc("<span \
class="phabricator-remarkup-mention-unknown">@action</span>:inmenu","Hide \
fully translated files"));<br /> action->setToolTip(i18nc("<span \
class="phabricator-remarkup-mention-unknown">@action</span>:inmenu","Hide \
fully translated files and folders"));</p>
<p style="padding: 0; margin: 8px;">So the tooltip on the toolbar gives some more \
info.</p>
<p style="padding: 0; margin: 8px;">What do you think? Or am i making a big deal of \
nothing? 😄</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Why not both ?</p>
<p style="padding: 0; margin: 8px;">I was thinking of something like \
"items" instead of "files and folders" but it would be more \
confusing, some people may think it would hide the translated strings within the \
files.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14219">https://phabricator.kde.org/D14219</a></div></div><br \
/><div><strong>To: </strong>sdepiets, aacid, Localization, ltoscano, shaforostoff, \
mlaurent, huftis<br /><strong>Cc: </strong>schwarzer, huftis, michaldybczak, \
sdepiets, skadinna<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic