[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D14219: Add a feature to hide translated files on the Project tab
From: Laurent Montel <noreply () phabricator ! kde ! org>
Date: 2018-07-19 5:48:00
Message-ID: 6c2ad588b004a91de1090f34f9c1daff () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> projectmanagerui.rc:2
> <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
> <kpartgui name="ProjectOverview" version="4">
> <MenuBar>
increase version when you add new entry in rc file
> projecttab.cpp:31
>
> +#include "lokalize_debug.h"
> +
why ? you don't add new debug in this file no ?
> projecttab.cpp:188
> + ac->setDefaultShortcut(action, QKeySequence(Qt::CTRL+Qt::Key_T));
> + connect( action, SIGNAL(triggered(bool)), this, SLOT(toggleTranslatedFiles()));
> +
it's better to use new connect api.
> projectwidget.cpp:155
>
> +void SortFilterProxyModel::toggleTranslatedFiles() { m_hideTranslatedFiles = !m_hideTranslatedFiles; }
>
coding style:
::foo()
{
...
}
REPOSITORY
R456 Lokalize
REVISION DETAIL
https://phabricator.kde.org/D14219
To: sdepiets, aacid, #localization, ltoscano, shaforostoff, mlaurent
Cc: michaldybczak, sdepiets, skadinna, huftis
[Attachment #3 (text/html)]
<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent \
added inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14219">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14219#inline-74872">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">projectmanagerui.rc:2</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "><!DOCTYPE kpartgui SYSTEM "kpartgui.dtd"> </div><div \
style="padding: 0 8px; margin: 0 4px; "><kpartgui name="ProjectOverview" \
version="4"> </div><div style="padding: 0 8px; margin: 0 4px; \
"><MenuBar> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">increase version when you add new entry in rc file</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14219#inline-74873">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">projecttab.cpp:31</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#include</span> <span \
class="cpf">"lokalize_debug.h"</span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">why ? you don't add new debug in this file no ?</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14219#inline-74874">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">projecttab.cpp:188</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">ac</span><span style="color: #aa2211">-></span><span \
class="n">setDefaultShortcut</span><span class="p">(</span><span \
class="n">action</span><span class="p">,</span> <span \
class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span \
style="color: #aa2211">::</span><span class="n">CTRL</span><span style="color: \
#aa2211">+</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">Key_T</span><span class="p">));</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">connect</span><span class="p">(</span> <span class="n">action</span><span \
class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span \
class="n">triggered</span><span class="p">(</span><span style="color: \
#aa4000">bool</span><span class="p">)),</span> <span style="color: \
#aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">toggleTranslatedFiles</span><span \
class="p">()));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">it's better to use new connect api.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14219#inline-74875">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">projectwidget.cpp:155</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">void</span> <span class="n">SortFilterProxyModel</span><span \
style="color: #aa2211">::</span><span class="n">toggleTranslatedFiles</span><span \
class="p">()</span> <span class="p">{</span> <span \
class="n">m_hideTranslatedFiles</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa2211">!</span><span class="n">m_hideTranslatedFiles</span><span \
class="p">;</span> <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">coding style:<br /> ::foo() <br />
{<br />
...<br />
}</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14219">https://phabricator.kde.org/D14219</a></div></div><br \
/><div><strong>To: </strong>sdepiets, aacid, Localization, ltoscano, shaforostoff, \
mlaurent<br /><strong>Cc: </strong>michaldybczak, sdepiets, skadinna, huftis<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic