[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop
From:       Burkhard_Lück <noreply () phabricator ! kde ! org>
Date:       2018-03-25 10:30:21
Message-ID: 20180325103021.1.6AAB71B5BA8578C4 () phabricator ! kde ! org
[Download RAW message or body]

lueck added a comment.


  In D11661#233341 <https://phabricator.kde.org/D11661#233341>, @hein wrote:
  
  > I disagree with this patch - I renamed things for consistency for a reason and \
emailed i18n-doc, so I expect the docs to get renamed.  
  
  Right you emailed i18n-doc, changed the X-DocPath to \
control/kcmlaunchfeedback/index.html, but not the install target in \
doc/kcontrol/kcmlaunch/CMakeLists.txt,  therefore the englisch documentation is not \
found.  
  The name of the docmessages catalog, the name of the translated docs and the \
install target for the translated docs are autogenerated by scripty.  Rename the \
translated docs is therefore no real option, the dir doc/kcontrol/kcmlaunch/ has to \
be renamed, another level of consistency ;-)  
  I will upload a new patch so fix this bug for the english and the language docs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: aacid, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">lueck added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11661">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11661#233341" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11661#233341</a>, <a \
href="https://phabricator.kde.org/p/hein/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@hein</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I disagree with this patch - I renamed \
things for consistency for a reason and emailed i18n-doc, so I expect the docs to get \
renamed.</p></div> </blockquote>

<p>Right you emailed i18n-doc, changed the X-DocPath to \
control/kcmlaunchfeedback/index.html, but not the install target in \
doc/kcontrol/kcmlaunch/CMakeLists.txt,<br /> therefore the englisch documentation is \
not found.</p>

<p>The name of the docmessages catalog, the name of the translated docs and the \
install target for the translated docs are autogenerated by scripty.<br /> Rename the \
translated docs is therefore no real option, the dir doc/kcontrol/kcmlaunch/ has to \
be renamed, another level of consistency ;-)</p>

<p>I will upload a new patch so fix this bug for the english and the language \
docs.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11661">https://phabricator.kde.org/D11661</a></div></div><br \
/><div><strong>To: </strong>lueck, Plasma, Localization, Documentation, \
davidedmundson, hein<br /><strong>Cc: </strong>aacid, hein, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]