[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D9883: Fix translations from Sane
From:       Kåre Särs <noreply () phabricator ! kde ! org>
Date:       2018-01-15 6:46:59
Message-ID: 20180115064659.1.60CC26B2ABEB5C49 () phabricator ! kde ! org
[Download RAW message or body]

sars accepted this revision.
sars added a comment.
This revision is now accepted and ready to land.


  Thanks! Besides the question about the conversion I think this is good to go.

INLINE COMMENTS

> ksaneoption.h:53
> +inline QString sane_i18n(const char *text) {
> +    return i18nd(SANE_TRANSLATION_DOMAIN, qPrintable(QLatin1String(text)));
> +}

Why the conversion: const char* -> QLatin1String -> const char* ?

REPOSITORY
  R382 KSane Library

BRANCH
  Applications/17.12

REVISION DETAIL
  https://phabricator.kde.org/D9883

To: ltoscano, sars
Cc: #localization

[Attachment #3 (unknown)]

<table><tr><td style="">sars accepted this revision.<br />sars added a comment.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9883" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Thanks! Besides the question about the \
conversion I think this is good to go.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9883#inline-45094" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ksaneoption.h:53</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> \
<span class="n">QString</span> <span class="n">sane_i18n</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span style="color: \
#aa4000">char</span> <span style="color: #aa2211">*</span><span \
class="n">text</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">return</span> <span class="n">i18nd</span><span \
class="p">(</span><span class="n">SANE_TRANSLATION_DOMAIN</span><span \
class="p">,</span> <span class="n">qPrintable</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="n">text</span><span class="p">)));</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Why the conversion: const char* -&gt; QLatin1String -&gt; const char* \
?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R382 KSane Library</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Applications/17.12</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9883" \
rel="noreferrer">https://phabricator.kde.org/D9883</a></div></div><br \
/><div><strong>To: </strong>ltoscano, sars<br /><strong>Cc: </strong>Localization<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]