[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default
From:       Kevin Funk <noreply () phabricator ! kde ! org>
Date:       2017-12-04 8:59:34
Message-ID: 20171204085934.124241.72AE33C440C8E440 () phabricator ! kde ! org
[Download RAW message or body]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  This shouldn't create any troubles with earlier CMake versions.
  
  Also note that we set the same properties unconditionally in newer Qt5 CMake \
macros: https://codereview.qt-project.org/#/c/207327

INLINE COMMENTS

> KF5I18NMacros.cmake:56
> )
> +      set_property(SOURCE ${_header} PROPERTY SKIP_AUTOMOC ON)
> list(APPEND ${_sources} ${_header})

`set_source_files_properties(${_header} ...)` is probably the more canonical way to \
do this.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9118

To: mpyne, #frameworks, #build_system, #localization, kfunk
Cc: aacid


[Attachment #3 (unknown)]

<table><tr><td style="">kfunk accepted this revision.<br />kfunk added a comment.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9118" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>This shouldn&#039;t create any troubles \
with earlier CMake versions.</p>

<p>Also note that we set the same properties unconditionally in newer Qt5 CMake \
macros: <a href="https://codereview.qt-project.org/#/c/207327" class="remarkup-link" \
target="_blank" rel="noreferrer">https://codereview.qt-project.org/#/c/207327</a></p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9118#inline-41219" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">KF5I18NMacros.cmake:56</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">      <span class="err">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: \
#304a96">set_property</span><span class="p">(</span><span style="color: \
#766510">SOURCE</span> <span style="color: #aa2211">${</span><span style="color: \
#001294">_header</span><span style="color: #aa2211">}</span> <span style="color: \
#766510">PROPERTY</span> <span style="color: #766510">SKIP_AUTOMOC</span> <span \
style="color: #766510">ON</span><span class="p">)</span> </div><div style="padding: 0 \
8px; margin: 0 4px; ">      <span style="color: #304a96">list</span><span \
class="p">(</span><span style="color: #766510">APPEND</span> <span style="color: \
#aa2211">${</span><span style="color: #001294">_sources</span><span style="color: \
#aa2211">}</span> <span style="color: #aa2211">${</span><span style="color: \
#001294">_header</span><span style="color: #aa2211">}</span><span class="p">)</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><tt style="background: #ebebeb; font-size: \
13px;">set_source_files_properties(${_header} ...)</tt> is probably the more \
canonical way to do this.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R249 KI18n</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9118" \
rel="noreferrer">https://phabricator.kde.org/D9118</a></div></div><br \
/><div><strong>To: </strong>mpyne, Frameworks, Build System, Localization, kfunk<br \
/><strong>Cc: </strong>aacid<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]