On 04.08.2017 22:54, Alexey Min wrote: > Hi, > I just wanted to ask if it is acceptable to push > https://phabricator.kde.org/D6319 to 17.08 branch before release? > > In short, it would improve user experience by not making them manually > edit config file ~/.config/krfbrc. > > In details: after removing old "x11" plugin and replacing it with > "xcb" (which was done in https://phabricator.kde.org/D5211 ) that > config file may have remaining incorrect "x11" saved setting, or as I > suggested in https://bugs.kde.org/show_bug.cgi?id=356782#c6, "qt". > With D6319, users having "x11" will be automatically switched to > "xcb", and those having "qt", may go to "Settings -> Configure Desktop > Sharing..." and change preference there; in both cases avoiding manual > editing of config file. > > Sorry for an inconvenience. > > > Cheers, > Alexey Minnekhanov > Hi Alexey, nobody raised any concern. If you are confident that the patch improves more than it breaks, you are granted the exception for the Applications/17.08 branch of 'krfb'. We are really tight to tagging, so I suggest to commit it as soon as you are reading this. Otherwise, the new strings might released untranslated. With some luck, it also gives us a week to do final testing of your work. Thanks, Christoph Feck