[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [Patch] Remove trailing whitespace from translated json files
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2017-04-08 10:48:42
Message-ID: 3985128.CQXfdQrgYj () xps
[Download RAW message or body]

El divendres, 7 d'abril de 2017, a les 18:28:49 CEST, Elvis Angelaccio va 
escriure:
> On Thu, Mar 30, 2017 at 1:08 AM, Luigi Toscano <luigi.toscano@tiscali.it> 
wrote:
> > Elvis Angelaccio ha scritto:
> >> Scripty adds trailing whitespace when committing translations to json
> >> files. This is annoying because the git diff output is polluted with
> >> visual warnings.
> >> 
> >> According to [1], python2 adds trailing whitespace when json.dumps has
> >> the indent parameter set. The same page also suggests the fix for
> >> this, which is what you can find in the attached patch.
> > 
> > Uhm, I would trust the python documentation (the behavior with python 3
> > seems a bit different; not a concert now  and you may want to add a
> > comment before the line as reminder to revisit this when it will be
> > important).
> > 
> > I would say: wait for the tagging of the next Frameworks and commit it to
> > trunk/l10n-kf5/scripts, and let's see.
> 
> Hi, it seems I don't have enough svn karma to push this patch. Can
> someone else please do it?

Done.

Cheers,
  Albert

> 
> Thanks!
> 
> > --
> > Luigi


[prev in list] [next in list] [prev in thread] [next in thread]