[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Request, 4 lines] D4795: Correctly load the Qt-native translations
From:       Luigi Toscano <noreply () phabricator ! kde ! org>
Date:       2017-02-25 21:52:05
Message-ID: differential-rev-PHID-DREV-is2owrg7tabc272wd2ti-req () phabricator ! kde ! org
[Download RAW message or body]

ltoscano created this revision.

REVISION SUMMARY
  ecm_create_qm_loader() uses Q_COREAPP_STARTUP_FUNCTION to inject the
  loader of the additiona translator. The macro does not seem to work
  when the loader is linked in a separate static library (the code
  which uses Qt translations is all inside libcore and libviews).
  So call the ECM macro (and then link the special loader) where
  the Q(Core)Application is defined.
  Many previously untranslated strings are not translated.

TEST PLAN
  The code compiles, and content of the right pane (coming from
  libviews and libcore) is now translated.

REPOSITORY
  R49 KCacheGrind

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4795

AFFECTED FILES
  CMakeLists.txt
  kcachegrind/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #localization
Cc: #localization

[Attachment #3 (text/html)]

<table><tr><td style="">ltoscano created this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4795" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>ecm_create_qm_loader() uses Q_COREAPP_STARTUP_FUNCTION to \
inject the<br /> loader of the additiona translator. The macro does not seem to \
work<br /> when the loader is linked in a separate static library (the code<br />
which uses Qt translations is all inside libcore and libviews).<br />
So call the ECM macro (and then link the special loader) where<br />
the Q(Core)Application is defined.<br />
Many previously untranslated strings are not translated.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>The code compiles, and content of the right \
pane (coming from<br /> libviews and libcore) is now translated.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R49 KCacheGrind</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4795" \
rel="noreferrer">https://phabricator.kde.org/D4795</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
kcachegrind/CMakeLists.txt</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ltoscano, Localization<br /><strong>Cc: \
</strong>Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]