[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 129888: use the genericname as comment
From: Harald Sitter <sitter () kde ! org>
Date: 2017-02-01 16:59:25
Message-ID: 20170201165925.10759.47103 () mimi ! kde ! org
[Download RAW message or body]
--===============7209520513433252602==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129888/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 4:59 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Games and Localization and Translation (l10n).
Changes
-------
Submitted with commit 399c99f82e995bba0681d58ae0ea7fb026621b94 by Harald Sitter to \
branch Applications/16.12.
Repository: ksquares
Description
-------
In absence of an appdata file, appstream tries to determine its required
fields through the desktop file, currently ksquares is missing a summary
which would get pulled from the Comment entry in the desktop file.
Since the GenericName can easily double as (not all too grand) Comment
here, simply copy it to reduce l10n work.
Not having appstream data prevents the application from showing up
in software stores we'll want this fixed in a bugfix release of 16.12.
Diffs
-----
src/org.kde.ksquares.desktop 629f1732b4da3791dfd8bc80c237c4ad9ece7f18
Diff: https://git.reviewboard.kde.org/r/129888/diff/
Testing
-------
Thanks,
Harald Sitter
--===============7209520513433252602==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129888/">https://git.reviewboard.kde.org/r/129888/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games and Localization and Translation (l10n).</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2017, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 399c99f82e995bba0681d58ae0ea7fb026621b94 by Harald \
Sitter to branch Applications/16.12.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksquares
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In absence of an appdata file, appstream tries to determine its required \
fields through the desktop file, currently ksquares is missing a summary which would \
get pulled from the Comment entry in the desktop file. Since the GenericName can \
easily double as (not all too grand) Comment here, simply copy it to reduce l10n \
work.
Not having appstream data prevents the application from showing up
in software stores we'll want this fixed in a bugfix release of 16.12.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/org.kde.ksquares.desktop <span style="color: \
grey">(629f1732b4da3791dfd8bc80c237c4ad9ece7f18)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129888/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7209520513433252602==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic