From kde-i18n-doc Thu Jan 26 10:12:39 2017 From: =?utf-8?q?Burkhard_L=C3=BCck?= Date: Thu, 26 Jan 2017 10:12:39 +0000 To: kde-i18n-doc Subject: Re: Review Request 129888: use the genericname as comment Message-Id: <20170126101239.28168.74005 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=148542556801963 --===============4771337158994023079== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129888/#review102248 ----------------------------------------------------------- +1 from de team - Burkhard Lück On Jan. 26, 2017, 9:55 vorm., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129888/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 9:55 vorm.) > > > Review request for KDE Games and Localization and Translation (l10n). > > > Repository: ksquares > > > Description > ------- > > In absence of an appdata file, appstream tries to determine its required > fields through the desktop file, currently ksquares is missing a summary > which would get pulled from the Comment entry in the desktop file. > Since the GenericName can easily double as (not all too grand) Comment > here, simply copy it to reduce l10n work. > > Not having appstream data prevents the application from showing up > in software stores we'll want this fixed in a bugfix release of 16.12. > > > Diffs > ----- > > src/org.kde.ksquares.desktop 629f1732b4da3791dfd8bc80c237c4ad9ece7f18 > > Diff: https://git.reviewboard.kde.org/r/129888/diff/ > > > Testing > ------- > > > Thanks, > > Harald Sitter > > --===============4771337158994023079== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129888/

+1 from de team

- Burkhard Lück

On Januar 26th, 2017, 9:55 vorm. UTC, Harald Sitter wrote:

Review request for KDE Games and Localization and Translation (l10n).

By Harald Sitter.

Updated Jan. 26, 2017, 9:55 vorm.

Repository: ksquares

Description

In absence of an appdata file, appstream tries to determine its required
fields through the desktop file, currently ksquares is missing a summary
which would get pulled from the Comment entry in the desktop file.
Since the GenericName can easily double as (not all too grand) Comment
here, simply copy it to reduce l10n work.

Not having appstream data prevents the application from showing up
in software stores we'll want this fixed in a bugfix release of 16.12.

Diffs

src/org.kde.ksquares.desktop (629f1732b4da3791dfd8bc80c237c4ad9ece7f18)

View Diff

--===============4771337158994023079==--