[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Requested Changes To] D4023: kformat: Make it possible to properly translate relativ
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2017-01-12 23:12:19
Message-ID: 20170112231219.3407.52374.0E82294D () phabricator ! kde ! org
[Download RAW message or body]

aacid requested changes to this revision.
aacid added a reviewer: aacid.
aacid added a comment.
This revision now requires changes to proceed.


  I find the comments misleading (maybe because i'm not english native) but
  
    if (daysTo < -1) {
          switch (date.dayOfWeek()) {
          case 1:
              return tr("Last Monday",    "day in the previous week");
          case 2:
  
  Why does it have to be the previous week? If today is Wednesday and the date we're \
referring to is Monday, daysTo will be -2 and it will still be the current week and \
not the previous, no?  
  else if (daysTo > 1) {
  
    switch (date.dayOfWeek()) {
    case 4:
        return tr("Next Thursday",  "day in the week after this");
  
  If today is Monday and the date we're referring to is Thursday, daysTo will be 3 \
and it's not "the week after this" it's "this week".  
  Or am i understanding something wrong?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4023

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, kde-i18n-doc, aspotashev, aacid
Cc: aacid


[Attachment #3 (text/html)]

<table><tr><td style="">aacid requested changes to this revision.<br />aacid added a \
reviewer: aacid.<br />aacid added a comment.<br />This revision now requires changes \
to proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4023" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I find the comments misleading (maybe \
because i&#039;m not english native) but</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (daysTo &lt; -1) {  switch \
(date.dayOfWeek()) {  case 1:
          return tr(&quot;Last Monday&quot;,    &quot;day in the previous \
week&quot;);  case 2:</pre></div>

<p>Why does it have to be the previous week? If today is Wednesday and the date \
we&#039;re referring to is Monday, daysTo will be -2 and it will still be the current \
week and not the previous, no?</p>

<p>else if (daysTo &gt; 1) {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">switch (date.dayOfWeek()) { \
case 4:  return tr(&quot;Next Thursday&quot;,  &quot;day in the week after \
this&quot;);</pre></div>

<p>If today is Monday and the date we&#039;re referring to is Thursday, daysTo will \
be 3 and it&#039;s not &quot;the week after this&quot; it&#039;s &quot;this \
week&quot;.</p>

<p>Or am i understanding something wrong?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4023" \
rel="noreferrer">https://phabricator.kde.org/D4023</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mpyne, Frameworks, kde-i18n-doc, aspotashev, aacid<br \
/><strong>Cc: </strong>aacid<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]