[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [Patch] Add newline at the end of translated json files
From:       Elvis Angelaccio <elvis.angelaccio () kde ! org>
Date:       2016-12-01 9:53:51
Message-ID: CALN1cnsBHBBoR4eedYgdS6CS2X5-co0Mo8tEniA3k2BKZs0EGw () mail ! gmail ! com
[Download RAW message or body]

On Thu, Nov 10, 2016 at 11:00 AM, Elvis Angelaccio
<elvis.angelaccio@kde.org> wrote:
> On Thu, Nov 10, 2016 at 8:25 AM, Burkhard Lück <lueck@hube-lueck.de> wrote:
>> Am Mittwoch, 9. November 2016, 15:19:10 CET schrieb Elvis Angelaccio:
>>> Hi,
>>> json files translated by scripty are currently created without an
>>> ending newline. Krazy complains about this (e.g. see first 9 issues in
>>> [1]), so I'm attaching a patch that should fix this (not tested
>>> though).
>>>
>>> Please have a look and consider applying it if it works.
>>>
>> krazy does not report an error anymore today, is this patch really required?
>
> Right, that's because I asked Allan to not look anymore in json files:
> https://bugs.kde.org/show_bug.cgi?id=372257
>
> However it's good practice to end all files with a newline anyway. For
> example also git "complains" about missing newlines in commits.
>

Ping?
I wonder if my patch would prevent useless commits such as [1]?

Cheers
Elvis

[1]: https://cgit.kde.org/ark.git/commit/?id=b26baebbdd43bbfc21b119993a81e2d281dcf106

> Cheers
>
>>
>> --
>> Burkhard Lück
>>
[prev in list] [next in list] [prev in thread] [next in thread]