[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Requested Changes To] D3523: Fix resizing of infopanel
From:       "elvisangelaccio (Elvis Angelaccio)" <noreply () phabricator ! kde ! org>
Date:       2016-11-27 17:28:12
Message-ID: 20161127172812.31622.99692.6A9D8170 () phabricator ! kde ! org
[Download RAW message or body]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> infopanel.cpp:178
>  
> -    m_typeLabel->setText(i18n("<b>Type:</b> %1",  mimeType.comment()));
> +    m_typeLabel->setText(i18n("Type: "));
> +    m_typeValueLabel->setText(mimeType.comment());

The "fixed" string can now be set directly in infopanel.ui

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3523

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, kde-i18n-doc, elvisangelaccio
Cc: kde-utils-devel, tctara

[Attachment #3 (text/html)]

<table><tr><td style="">elvisangelaccio requested changes to this revision.<br \
/>elvisangelaccio added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3523" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3523#inline-13755" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">infopanel.cpp:178</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;">    <span class="n">m_typeLabel</span><span style="color: \
#aa2211">-&gt;</span><span class="n">setText</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span style="color: #766510">&quot;<span \
class="bright">&lt;b&gt;</span>Type:<span class="bright">&lt;/b&gt; \
%1&quot;</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright">  </span><span class="n"><span \
class="bright">mimeType</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">comment</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>));</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    <span class="n">m_typeLabel</span><span \
style="color: #aa2211">-&gt;</span><span class="n">setText</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
style="color: #766510">&quot;Type:<span class="bright"> &quot;</span></span><span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">    <span class="n">m_typeValueLabel</span><span style="color: \
#aa2211">-&gt;</span><span class="n">setText</span><span class="p">(</span><span \
class="n">mimeType</span><span class="p">.</span><span class="n">comment</span><span \
class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
&quot;fixed&quot; string can now be set directly in \
infopanel.ui</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3523" \
rel="noreferrer">https://phabricator.kde.org/D3523</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>rthomsen, kde-i18n-doc, elvisangelaccio<br /><strong>Cc: \
</strong>kde-utils-devel, tctara<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]