[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: i18n issues in Spectacle
From:       Peter Wu <peter () lekensteyn ! nl>
Date:       2016-10-24 18:17:48
Message-ID: 20161024181748.GB10138 () al
[Download RAW message or body]

Hi,

I have taken a look at the i18n issues in Spectacle, see below.

On Wed, Oct 12, 2016 at 03:25:20AM +0530, Boudhayan Gupta wrote:
> Adding Peter Wu to the thread, since he volunteered to fix this.
> 
> Peter: read trail mail below.
> 
> On 7 October 2016 at 04:18, Albert Astals Cid <aacid@kde.org> wrote:
> 
> > El diumenge, 11 de setembre de 2016, a les 22:59:46 CEST, Boudhayan Gupta
> > va
> > escriure:
> > > Hi Alexander,
> > >
> > > On 7 September 2016 at 04:14, Alexander Potashev <aspotashev@gmail.com>
> > wrote:
> > > > Hi Boudhayan,
> > > >
> > > > I'm writing to notify you of the following issues in translatable
> > > >
> > > > strings in Spectacle:
> > > >  1. KDE HIG says [1] "Use an ellipsis (...) after menu items and
> > > >
> > > > button labels which require user's input before completing their
> > > > action."
> > > >
> > > > The following string is the case because it opens the application
> > > > selection dialog:
> > > >
> > > > #: src/Gui/ExportMenu.cpp:110
> > > > msgid "Other Application"

OK, seems reasonable.

> > > >  2. Same here:
> > > > #: src/Gui/KSMainWindow.cpp:225
> > > > src/Gui/SettingsDialog/SettingsDialog.cpp:36 msgid "Preferences"
> > > >
> > > > Sorry, I'm lazy to check which one is menu item and which is window
> > > > title. I suggest the menu item to be renamed "Configure Spectacle...",
> > > > the window title be "Configure Spectacle" or just "Configure" (since "
> > > > - Spectacle" is appended anyway by KWin), preferably with a
> > > > @title:window context string [2].

This would also need more documentation changes, but "Preferences"
(without ellipsis) seems a valid option:
https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels

Would you still prefer "Configure Spectacle" (with ellipsis on the
button, without ellipsis in the window title)?

> > > >  3. Term inconsistency: "monitor" in "Full Screen (All Monitors)" vs
> > > > "screen" in "Current Screen" while you're obviously referring to the
> > > > same kind of thing.
> > > >
> > > > #: src/Gui/KSWidget.cpp:59
> > > > msgid "Full Screen (All Monitors)"
> > > >
> > > > #: src/Gui/KSWidget.cpp:60
> > > > msgid "Current Screen"

Two ways to "fix" this, either rewrite as "Full Screen (All Screens)" or
rewrite the latter to "Current Monitor". Now "Monitor" often refers to
hardware while "Screen" seems a logical concept.

I think "Full Screen (All Screens)" does not seem to improve the
meaning. Do you have suggestions?

Full screen is supposed to take a screenshot of all screens (instead of
"full screen" when there is only one screen.  Current screen just covers
the current screen.

Maybe it would make sense to hide the "Current screen" option when "Full
screen" would give the same result? Then we have:

 - multiple monitors: "All Screens" and "Current Screen"
 - single monitor" "Full Screen"

> > > >  5. Please use proper plurals instead of hardcoding n <= 1 ? 0 : 1
> > here:
> > > > #: src/Gui/SmartSpinBox.cpp:43
> > > > msgid " second"
> > > >
> > > > #: src/Gui/SmartSpinBox.cpp:45
> > > > msgid " seconds"
> > > >
> > > > I guess you can use i18np() for integers and another i18n() for
> > > > decimal fractions.

I have fixed it locally to check for n == 1.0 to have 0 seconds, 1
second, 1.1 seconds, 2 seconds, etc. I did have an issue with using
i18np on real numbers though, please see:
https://bugs.kde.org/show_bug.cgi?id=341692

By the way, the "Save As" button would also benefit from ellipsis for
consistency (following the menu example in Kate for example), but the
KStandardAction API does not seem to support that.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
[prev in list] [next in list] [prev in thread] [next in thread]